Skip to content

fix(ddtrace/tracer): fix seelog goroutine leak#3818

Merged
dd-mergequeue[bot] merged 2 commits into
mainfrom
push-pxlkurquylwk
Jul 30, 2025
Merged

fix(ddtrace/tracer): fix seelog goroutine leak#3818
dd-mergequeue[bot] merged 2 commits into
mainfrom
push-pxlkurquylwk

Conversation

@felixge

@felixge felixge commented Jul 30, 2025

Copy link
Copy Markdown
Member

This is a workaround until we can implement a proper solution.

Fixes #2987

What does this PR do?

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@felixge
felixge requested a review from a team as a code owner July 30, 2025 11:16
@felixge
felixge force-pushed the push-pxlkurquylwk branch from 18dd718 to 63ccf63 Compare July 30, 2025 11:17
@pr-commenter

pr-commenter Bot commented Jul 30, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-07-30 11:51:54

Comparing candidate commit cd20496 in PR branch push-pxlkurquylwk with baseline commit 6e548d5 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@felixge
felixge force-pushed the push-pxlkurquylwk branch from 11ca9af to cd20496 Compare July 30, 2025 11:39
genesor
genesor approved these changes Jul 30, 2025
View reviewed changes

@genesor genesor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for handling it

@felixge

felixge commented Jul 30, 2025

Copy link
Copy Markdown
Member Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Jul 30, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-07-30 12:07:24 UTC ℹ️ Start processing command /merge

2025-07-30 12:07:30 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 14m (p90).

2025-07-30 12:20:01 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit 4480201 into main Jul 30, 2025
313 of 315 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the push-pxlkurquylwk branch July 30, 2025 12:19
eliottness pushed a commit that referenced this pull request Jul 30, 2025
@felixge @eliottness
fix(ddtrace/tracer): fix seelog goroutine leak (#3818)
82ecf65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@genesor genesor genesor approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] unexpected goroutines remain in service after upgrading from 1.69.1 to 1.70.1

2 participants

@felixge @genesor