Skip to content

chore(tools/v2fix): upgrade dd-trace-go.v1 to avoid v2 non-compatible warning#3814

Merged
dd-mergequeue[bot] merged 1 commit into
mainfrom
dario.castane/langplat-707/v2fix-upgrade-tracer
Jul 30, 2025
Merged

chore(tools/v2fix): upgrade dd-trace-go.v1 to avoid v2 non-compatible warning#3814
dd-mergequeue[bot] merged 1 commit into
mainfrom
dario.castane/langplat-707/v2fix-upgrade-tracer

Conversation

@darccio

@darccio darccio commented Jul 29, 2025

Copy link
Copy Markdown
Member

What does this PR do?

Closes #3791 #3804 by upgrading the v1 tracer, as the customer did in #3804. The reason to not adopt the customer's PR is because they are introducing multiple changes regarding Go versions and libraries that are not related to upgrading the v1 tracer.

Motivation

The warning that the customer reports in #3791 is because both tracer versions - v1 and v2 - are bundled into v2fix due to the way it was designed. It's not a blocking warning, as it has no impact in v2fix checks.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@pr-commenter

pr-commenter Bot commented Jul 29, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-07-30 08:41:17

Comparing candidate commit 3979a1c in PR branch dario.castane/langplat-707/v2fix-upgrade-tracer with baseline commit 229781c in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@hannahkm

hannahkm commented Jul 29, 2025

Copy link
Copy Markdown
Contributor

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Jul 29, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-07-29 18:49:26 UTC ℹ️ Start processing command /merge

2025-07-29 18:49:36 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 14m (p90).

2025-07-29 19:02:13 UTC ❌ MergeQueue: The checks failed on this merge request

Tests failed on this commit c639002:

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.

@hannahkm

hannahkm commented Jul 29, 2025

Copy link
Copy Markdown
Contributor

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Jul 29, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-07-29 19:17:58 UTC ℹ️ Start processing command /merge

2025-07-29 19:18:08 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 14m (p90).

2025-07-29 19:27:38 UTC ❌ MergeQueue: The checks failed on this merge request

Tests failed on this commit 3df1ce7:

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.

@darccio

darccio commented Jul 30, 2025

Copy link
Copy Markdown
Member Author

Personal note: Don't forget to eat your veggies run ./scripts/generate.sh & ./scripts/fix_modules.sh when editing any go.mod file.

@darccio
darccio force-pushed the dario.castane/langplat-707/v2fix-upgrade-tracer branch from 12ab454 to 3979a1c Compare July 30, 2025 08:28
@darccio

darccio commented Jul 30, 2025

Copy link
Copy Markdown
Member Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Jul 30, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-07-30 08:29:25 UTC ℹ️ Start processing command /merge

2025-07-30 08:29:34 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-07-30 08:51:15 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 14m (p90).

2025-07-30 09:02:46 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit 6e548d5 into main Jul 30, 2025
243 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the dario.castane/langplat-707/v2fix-upgrade-tracer branch July 30, 2025 09:02
@darccio darccio mentioned this pull request Jul 30, 2025
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hannahkm hannahkm hannahkm approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG]: tool v2fix does not work

2 participants

@darccio @hannahkm