ci: enable new macrobenchmark envoy scenarios with bodies#3805
Merged
Conversation
e-n-0
force-pushed
the
flavien/envoy/benchmarkingplatform
branch
from
July 23, 2025 12:36
d8cc2b2 to
77e2fcc
Compare
BenchmarksBenchmark execution time: 2025-07-23 13:03:19 Comparing candidate commit bfd2dfc in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics. |
e-n-0
force-pushed
the
flavien/envoy/benchmarkingplatform
branch
from
July 23, 2025 12:50
77e2fcc to
bfd2dfc
Compare
eliottness
approved these changes
Jul 23, 2025
hannahkm
approved these changes
Jul 23, 2025
Member
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
dd-devflow
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
dd-devflow
Bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR enable the 2 new scenarios implemented in the benchmarking platform with bodies processing.
se-ext_proc-body-appsec: External Processor enabled in Envoy (with appsec) with body processingse-ext_proc-body-only-tracing: External Processor enabled in Envoy (without appsec) with body processingNew updated dashboard
These changes are related to this PR: https://github.com/DataDog/benchmarking-platform/pull/175 (waiting for this PR to be merged first)
Motivation
More QA with the new release with body processing.
Reviewer's Checklist
./scripts/lint.shlocally.Unsure? Have a question? Request a review!