appsec: support for go 1.25#3739
Merged
Merged
Conversation
github-actions
Bot
added
the
apm:ecosystem
eliottness
marked this pull request as ready for review
July 9, 2025 11:53
BenchmarksBenchmark execution time: 2025-07-09 12:05:34 Comparing candidate commit e803875 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics. |
RomainMuller
approved these changes
Jul 9, 2025
Contributor
Author
Merge activity
|
eliottness
added a commit
that referenced
this pull request
Jul 9, 2025
<!-- * New contributors are highly encouraged to read our [CONTRIBUTING](/CONTRIBUTING.md) documentation. * Commit and PR titles should be prefixed with the general area of the pull request's change. --> This PR upgrades go-libddwaf to v4.3.0. Unlock go 1.25 for appsec customers <!-- * Authors can use this list as a reference to ensure that there are no problems during the review but the signing off is to be done by the reviewer(s). --> - [ ] Changed code has unit tests for its functionality at or near 100% coverage. - [ ] [System-Tests](https://github.com/DataDog/system-tests/) covering this feature have been added and enabled with the va.b.c-dev version tag. - [ ] There is a benchmark for any new code, or changes to existing code. - [ ] If this interacts with the agent in a new way, a system test has been added. - [ ] New code is free of linting errors. You can check this by running `golangci-lint run` locally. - [ ] Add an appropriate team label so this PR gets put in the right place for the release notes. - [ ] Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild. Unsure? Have a question? Request a review!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR upgrades go-libddwaf to v4.3.0.
Motivation
Unlock go 1.25 for appsec customers
Reviewer's Checklist
golangci-lint runlocally.Unsure? Have a question? Request a review!