fix: orchestrion metadata not propagated into the config object#3734
Merged
Conversation
This appears to have gone missing from the original PR that introduced baked-in orchestrion metadata + telemetry reporting of orchestrion enablement, resulting in all that machinery being effectively non-operant.
BenchmarksBenchmark execution time: 2025-07-08 08:29:41 Comparing candidate commit 0a4d290 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics. |
RomainMuller
enabled auto-merge (squash)
July 8, 2025 08:48
eliottness
approved these changes
Jul 8, 2025
genesor
approved these changes
Jul 8, 2025
genesor
pushed a commit
that referenced
this pull request
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Sets
config.orchestrionConfigat start-up based on baked-in values.Motivation
This appears to have gone missing from the original PR that introduced baked-in orchestrion metadata + telemetry reporting of orchestrion enablement, resulting in all that machinery being effectively non-operant.
Reviewer's Checklist
golangci-lint runlocally.Unsure? Have a question? Request a review!