Skip to content

chore(contrib/olivere/elastic.v5): http.RoundTripper for transport#3693

Merged
dd-mergequeue[bot] merged 3 commits into
mainfrom
isaacdd-patch-1
Aug 18, 2025
Merged

chore(contrib/olivere/elastic.v5): http.RoundTripper for transport#3693
dd-mergequeue[bot] merged 3 commits into
mainfrom
isaacdd-patch-1

Conversation

@isaacdd

@isaacdd isaacdd commented Jun 25, 2025

Copy link
Copy Markdown
Contributor

Use http.RoundTripper interface for transport option to be able to support custom HTTP transports.

What does this PR do?

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running golangci-lint run locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@isaacdd
[olivere] Use http.RoundTripper interface for transport option
befe083 
Use http.RoundTripper interface for transport option to be able to support custom HTTP transports.
@github-actions github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label Jun 25, 2025
@pr-commenter

pr-commenter Bot commented Jun 25, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-08-14 07:47:37

Comparing candidate commit bf1a57d in PR branch isaacdd-patch-1 with baseline commit e4a3652 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jun 25, 2025

Copy link
Copy Markdown

Datadog Report

Branch report: isaacdd-patch-1
Commit report: 600fda8
Test service: dd-trace-go

✅ 0 Failed, 5420 Passed, 67 Skipped, 4m 28.11s Total Time

@genesor genesor changed the title [olivere] Use http.RoundTripper interface for transport option chore(contrib/olivere/elastic.v5): http.RoundTripper for transport Aug 14, 2025
@genesor
genesor marked this pull request as ready for review August 14, 2025 07:31
@genesor
genesor requested review from a team as code owners August 14, 2025 07:31
@genesor
genesor requested a review from a team as a code owner August 14, 2025 07:34
@genesor

genesor commented Aug 18, 2025

Copy link
Copy Markdown
Member

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Aug 18, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-08-18 09:28:18 UTC ℹ️ Start processing command /merge

2025-08-18 09:28:23 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 14m (p90).

2025-08-18 09:29:31 UTC ⚠️ MergeQueue: This merge request build was cancelled

[email protected] cancelled this merge request build

@genesor

genesor commented Aug 18, 2025

Copy link
Copy Markdown
Member

/merge --cancel

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Aug 18, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-08-18 09:29:22 UTC ℹ️ Start processing command /merge --cancel

@genesor

genesor commented Aug 18, 2025

Copy link
Copy Markdown
Member

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Aug 18, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-08-18 12:59:16 UTC ℹ️ Start processing command /merge

2025-08-18 12:59:23 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 14m (p90).

2025-08-18 13:11:53 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit 7f812b0 into main Aug 18, 2025
222 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the isaacdd-patch-1 branch August 18, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@genesor genesor genesor approved these changes
@rarguelloF rarguelloF rarguelloF approved these changes

Assignees

No one assigned

Labels

apm:ecosystem contrib/* related feature requests or bugs mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@isaacdd @genesor @rarguelloF