Skip to content

instrumentation: stop sending telemetry logs for each log a contrib would send to stdout#3684

Merged
eliottness merged 2 commits into
mainfrom
eliottness/remove-contrib-telemetry-logs
Jun 24, 2025
Merged

instrumentation: stop sending telemetry logs for each log a contrib would send to stdout#3684
eliottness merged 2 commits into
mainfrom
eliottness/remove-contrib-telemetry-logs

Conversation

@eliottness

@eliottness eliottness commented Jun 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR stops reporting all contriberrors that would be on stdout to telemetry.

Partial revert of: https://github.com/DataDog/dd-trace-go/pull/3294/files

Motivation

Some logs can incluse sensitive data.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running golangci-lint run locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@eliottness
eliottness requested a review from a team as a code owner June 24, 2025 11:05
@pr-commenter

pr-commenter Bot commented Jun 24, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-06-24 13:19:49

Comparing candidate commit 99736f9 in PR branch eliottness/remove-contrib-telemetry-logs with baseline commit ce459e6 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

RomainMuller
RomainMuller approved these changes Jun 24, 2025
View reviewed changes

@RomainMuller RomainMuller left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming we're quite convinced this is "all the places"

@eliottness

eliottness commented Jun 24, 2025

Copy link
Copy Markdown
Contributor Author

I would say I am 99% sure this is the only dangerous place right now. The last one 1% can be covered by @rarguelloF once he is out of PTo

Original PR: https://github.com/DataDog/dd-trace-go/pull/3294/files from @ygree

@eliottness
eliottness force-pushed the eliottness/remove-contrib-telemetry-logs branch from b3256e4 to d59ed8a Compare June 24, 2025 11:30
@eliottness
eliottness enabled auto-merge (squash) June 24, 2025 13:07
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jun 24, 2025 •
edited
Loading

Copy link
Copy Markdown

Datadog Report

Branch report: eliottness/remove-contrib-telemetry-logs
Commit report: 9a3f625
Test service: dd-trace-go

✅ 0 Failed, 70 Passed, 0 Skipped, 4m 29.93s Total Time

@eliottness
eliottness merged commit 897f65b into main Jun 24, 2025
219 checks passed
@eliottness
eliottness deleted the eliottness/remove-contrib-telemetry-logs branch June 24, 2025 13:24
genesor pushed a commit that referenced this pull request Jun 24, 2025
@eliottness @genesor
instrumentation: stop sending telemetry logs for each log a contrib w…
17da9f9 
…ould send to stdout (#3684)
genesor pushed a commit that referenced this pull request Jun 26, 2025
@eliottness @genesor
instrumentation: stop sending telemetry logs for each log a contrib w…
c577c51 
…ould send to stdout (#3684)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RomainMuller RomainMuller RomainMuller approved these changes
@kakkoyun kakkoyun kakkoyun approved these changes
@genesor genesor genesor approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eliottness @RomainMuller @kakkoyun @genesor