Skip to content

fix(ddtrace/tracer): add test and fix for deadlock issue #3541 in remote configuration#3667

Merged
darccio merged 2 commits into
mainfrom
dario.castane/langplat-601/remoteconfig-deadlock
Jun 20, 2025
Merged

fix(ddtrace/tracer): add test and fix for deadlock issue #3541 in remote configuration#3667
darccio merged 2 commits into
mainfrom
dario.castane/langplat-601/remoteconfig-deadlock

Conversation

@darccio

@darccio darccio commented Jun 19, 2025

Copy link
Copy Markdown
Member

What does this PR do?

Fix deadlock reported in #3541.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running golangci-lint run locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@darccio
darccio requested review from a team as code owners June 19, 2025 18:58
@pr-commenter

pr-commenter Bot commented Jun 19, 2025

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-06-20 08:01:00

Comparing candidate commit a4aefc8 in PR branch dario.castane/langplat-601/remoteconfig-deadlock with baseline commit 2bcfa37 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@darccio
darccio enabled auto-merge (squash) June 20, 2025 07:48
@darccio
darccio merged commit bd44033 into main Jun 20, 2025
220 checks passed
@darccio
darccio deleted the dario.castane/langplat-601/remoteconfig-deadlock branch June 20, 2025 08:05
genesor pushed a commit that referenced this pull request Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants