Skip to content

fix: data race in civisibility/integrations/logs/logs_payload.go#3666

Merged
darccio merged 1 commit into
mainfrom
dario.castane/langplat-602/fix-civis-data-race
Jun 19, 2025
Merged

fix: data race in civisibility/integrations/logs/logs_payload.go#3666
darccio merged 1 commit into
mainfrom
dario.castane/langplat-602/fix-civis-data-race

Conversation

@darccio

@darccio darccio commented Jun 19, 2025

Copy link
Copy Markdown
Member

What does this PR do?

Protects logsPayload concurrent using its mutex.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running golangci-lint run locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@pr-commenter

pr-commenter Bot commented Jun 19, 2025

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-06-19 16:56:26

Comparing candidate commit 47299e4 in PR branch dario.castane/langplat-602/fix-civis-data-race with baseline commit 02264cf in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@darccio
darccio force-pushed the dario.castane/langplat-602/fix-civis-data-race branch from 0fd9478 to 47299e4 Compare June 19, 2025 16:41
@darccio
darccio marked this pull request as ready for review June 19, 2025 16:44
@darccio
darccio requested a review from a team as a code owner June 19, 2025 16:44
@darccio
darccio requested a review from gnufede June 19, 2025 16:44
@darccio
darccio merged commit 14904e0 into main Jun 19, 2025
219 checks passed
@darccio
darccio deleted the dario.castane/langplat-602/fix-civis-data-race branch June 19, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant