ddtrace/tracer: cap execution tracer task name length#3658
Merged
Conversation
We use the span resource as the name for execution tracer task annotations. The resource can be an arbitrarily large string, like an SQL query, and the execution tracer can fail to allocate space for it in its string table and crash. The task name isn't really used for anything right now other than debugging. Cap the task name at some arbitrary length to mitigate this.
nsrip-dd
marked this pull request as ready for review
June 18, 2025 18:28
darccio
approved these changes
Jun 19, 2025
darccio
enabled auto-merge (squash)
June 19, 2025 08:21
genesor
pushed a commit
that referenced
this pull request
Jun 19, 2025
Co-authored-by: Dario Castañé <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We use the span resource as the name for execution tracer task
annotations. The resource can be an arbitrarily large string, like an
SQL query, and the execution tracer can fail to allocate space for it in
its string table and crash. The task name isn't really used for anything
right now other than debugging. Cap the task name at some arbitrary
length to mitigate this.
Motivation
Prevent crashes
Reviewer's Checklist
golangci-lint runlocally.