Skip to content

envoyproxy: support simdjson body parsing#3643

Merged
eliottness merged 2 commits into
eliottness/fix-misc-jsoniterfrom
eliottness/simdjson
Jun 20, 2025
Merged

envoyproxy: support simdjson body parsing#3643
eliottness merged 2 commits into
eliottness/fix-misc-jsoniterfrom
eliottness/simdjson

Conversation

@eliottness

@eliottness eliottness commented Jun 16, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

Use https://github.com/minio/simdjson-go for better json parsing performances

Previous benchmarks:

image.png

New benchmarks:

image.png

Motivation

Between 5 and 20 times better CPU performances and between 10 to 100 times better memory allocations, benchmark says.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running golangci-lint run locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@github-actions github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label Jun 16, 2025

eliottness commented Jun 16, 2025

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@eliottness eliottness mentioned this pull request Jun 16, 2025
7 tasks
@eliottness
eliottness requested review from RomainMuller and e-n-0 June 16, 2025 15:30
@eliottness
eliottness marked this pull request as ready for review June 16, 2025 15:31
@eliottness
eliottness requested a review from a team as a code owner June 16, 2025 15:31
@pr-commenter

pr-commenter Bot commented Jun 16, 2025

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-06-19 23:08:37

Comparing candidate commit d07ff43 in PR branch eliottness/simdjson with baseline commit 24fe947 in branch eliottness/fix-misc-jsoniter.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

@e-n-0
e-n-0 force-pushed the eliottness/fix-misc-jsoniter branch from 43b712e to 24fe947 Compare June 19, 2025 22:23
@e-n-0
e-n-0 force-pushed the eliottness/simdjson branch from 594f3a4 to d07ff43 Compare June 19, 2025 22:25
@eliottness
eliottness merged commit e939117 into eliottness/fix-misc-jsoniter Jun 20, 2025
238 checks passed
@eliottness
eliottness deleted the eliottness/simdjson branch June 20, 2025 13:24
eliottness added a commit that referenced this pull request Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

apm:ecosystem contrib/* related feature requests or bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants