Skip to content

envoyproxy: fix misc jsoniter#3642

Merged
eliottness merged 3 commits into
mainfrom
eliottness/fix-misc-jsoniter
Jun 25, 2025
Merged

envoyproxy: fix misc jsoniter#3642
eliottness merged 3 commits into
mainfrom
eliottness/fix-misc-jsoniter

Conversation

@eliottness

@eliottness eliottness commented Jun 16, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Fix misc issues with jsoniter implementation

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running golangci-lint run locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@github-actions github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label Jun 16, 2025
@eliottness
eliottness requested a review from e-n-0 June 16, 2025 15:29
@eliottness Graphite App

eliottness commented Jun 16, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@eliottness eliottness mentioned this pull request Jun 16, 2025
Merged
7 tasks
@pr-commenter

pr-commenter Bot commented Jun 16, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-06-25 10:07:02

Comparing candidate commit ddf1acc in PR branch eliottness/fix-misc-jsoniter with baseline commit d2b0acd in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@eliottness
eliottness marked this pull request as ready for review June 18, 2025 09:37
@eliottness
eliottness requested a review from a team as a code owner June 18, 2025 09:37
@eliottness @e-n-0
envoyproxy: fix misc jsoniter
24fe947 
Signed-off-by: Eliott Bouhana <[email protected]>
@e-n-0
e-n-0 force-pushed the eliottness/fix-misc-jsoniter branch from 43b712e to 24fe947 Compare June 19, 2025 22:23
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jun 25, 2025

Copy link
Copy Markdown

Datadog Report

Branch report: eliottness/fix-misc-jsoniter
Commit report: 6c5490c
Test service: dd-trace-go

✅ 0 Failed, 70 Passed, 0 Skipped, 4m 26.27s Total Time

@eliottness
eliottness enabled auto-merge (squash) June 25, 2025 10:12
@eliottness
eliottness merged commit deedd5b into main Jun 25, 2025
240 checks passed
@eliottness
eliottness deleted the eliottness/fix-misc-jsoniter branch June 25, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RomainMuller RomainMuller RomainMuller approved these changes
@e-n-0 e-n-0 e-n-0 approved these changes

Assignees

No one assigned

Labels

apm:ecosystem contrib/* related feature requests or bugs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eliottness @RomainMuller @e-n-0