refactor(ddtrace/tracer): remove unused Submit and SubmitChunk methods, unexpose Chunk type#3641
Merged
Merged
Conversation
BenchmarksBenchmark execution time: 2025-06-16 13:46:26 Comparing candidate commit ba32dc0 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics. |
…s, unexpose Chunk type This commit cleans up the tracer implementation by removing the unused Submit and SubmitChunk methods. Additionally, it updates the Chunk type to chunk in various places throughout the codebase. Signed-off-by: Kemal Akkoyun <[email protected]>
kakkoyun
force-pushed
the
kakkoyun/remove_leftover_apis
branch
from
June 16, 2025 10:17
be2445c to
f61eb4a
Compare
darccio
approved these changes
Jun 17, 2025
mtoffl01
pushed a commit
that referenced
this pull request
Jun 23, 2025
…s, unexpose Chunk type (#3641) Signed-off-by: Kemal Akkoyun <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit cleans up the tracer implementation by removing the unused Submit and SubmitChunk methods.
Additionally, it updates the Chunk type to chunk in various places throughout the codebase.
Signed-off-by: Kemal Akkoyun [email protected]
What does this PR do?
This PR refactors the tracer implementation by:
SubmitandSubmitChunkmethods from the public APIChunktype by renaming it tochunk(making it private)This is a follow-up to:
Motivation
The changes improve code maintainability by:
Reviewer's Checklist
golangci-lint runlocally.