Skip to content

refactor(ddtrace/tracer): remove unused Submit and SubmitChunk methods, unexpose Chunk type#3641

Merged
darccio merged 2 commits into
mainfrom
kakkoyun/remove_leftover_apis
Jun 17, 2025
Merged

refactor(ddtrace/tracer): remove unused Submit and SubmitChunk methods, unexpose Chunk type#3641
darccio merged 2 commits into
mainfrom
kakkoyun/remove_leftover_apis

Conversation

@kakkoyun

Copy link
Copy Markdown
Member

This commit cleans up the tracer implementation by removing the unused Submit and SubmitChunk methods.
Additionally, it updates the Chunk type to chunk in various places throughout the codebase.

Signed-off-by: Kemal Akkoyun [email protected]

What does this PR do?

This PR refactors the tracer implementation by:

  • Removing unused Submit and SubmitChunk methods from the public API
  • Unexposing the Chunk type by renaming it to chunk (making it private)
  • Updating all related code to use the new private type
  • Cleaning up the public API surface to be more maintainable

This is a follow-up to:

Motivation

The changes improve code maintainability by:

  • Reducing the public API surface by removing unused methods
  • Making internal implementation details private where appropriate
  • Simplifying the codebase by removing unnecessary public interfaces
  • Following Go best practices of keeping implementation details private
  • Continuing the cleanup work started in the referenced PRs

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running golangci-lint run locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

@kakkoyun
kakkoyun requested a review from darccio June 16, 2025 09:57
@kakkoyun
kakkoyun marked this pull request as ready for review June 16, 2025 09:58
@kakkoyun
kakkoyun requested a review from a team as a code owner June 16, 2025 09:58
@kakkoyun
kakkoyun changed the base branch from main to kakkoyun/improve_api_extractor June 16, 2025 09:59
@kakkoyun
kakkoyun changed the base branch from kakkoyun/improve_api_extractor to main June 16, 2025 10:00
@pr-commenter

pr-commenter Bot commented Jun 16, 2025

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-06-16 13:46:26

Comparing candidate commit ba32dc0 in PR branch kakkoyun/remove_leftover_apis with baseline commit 809550c in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

…s, unexpose Chunk type

This commit cleans up the tracer implementation by removing the unused Submit and SubmitChunk methods.
Additionally, it updates the Chunk type to chunk in various places throughout the codebase.

Signed-off-by: Kemal Akkoyun <[email protected]>
@kakkoyun
kakkoyun force-pushed the kakkoyun/remove_leftover_apis branch from be2445c to f61eb4a Compare June 16, 2025 10:17
@kakkoyun
kakkoyun requested a review from tonyredondo June 16, 2025 10:34

@tonyredondo tonyredondo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darccio
darccio merged commit 6a2d46f into main Jun 17, 2025
219 checks passed
@darccio
darccio deleted the kakkoyun/remove_leftover_apis branch June 17, 2025 12:29
mtoffl01 pushed a commit that referenced this pull request Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants