Skip to content

envoyproxy: rework json encoder#3635

Merged
eliottness merged 3 commits into
flavien/json-encoderfrom
eliottness/jsoniter-envoy
Jun 13, 2025
Merged

envoyproxy: rework json encoder#3635
eliottness merged 3 commits into
flavien/json-encoderfrom
eliottness/jsoniter-envoy

Conversation

@eliottness

@eliottness eliottness commented Jun 13, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR is the result of the review of #3550

Motivation

image

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running golangci-lint run locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@eliottness
rework jsoniter encoder
dc40e02 
Signed-off-by: Eliott Bouhana <[email protected]>
@eliottness
make append implemn working
9e6095b 
Signed-off-by: Eliott Bouhana <[email protected]>
@eliottness
fix last bugs in encoding
031237f 
Signed-off-by: Eliott Bouhana <[email protected]>
@eliottness
eliottness requested review from a team as code owners June 13, 2025 11:24
e-n-0
e-n-0 approved these changes Jun 13, 2025
View reviewed changes

@e-n-0 e-n-0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇‍♂️

@eliottness
eliottness merged commit 5d33319 into flavien/json-encoder Jun 13, 2025
12 of 189 checks passed
@eliottness
eliottness deleted the eliottness/jsoniter-envoy branch June 13, 2025 11:27
@github-actions github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label Jun 13, 2025
e-n-0 pushed a commit that referenced this pull request Jun 13, 2025
@eliottness @e-n-0
envoyproxy: rework json encoder (#3635)
c869d16 
Signed-off-by: Eliott Bouhana <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@e-n-0 e-n-0 e-n-0 approved these changes

Assignees

No one assigned

Labels

apm:ecosystem contrib/* related feature requests or bugs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eliottness @e-n-0