Skip to content

internal/appsec: report appsec start error#3631

Merged
eliottness merged 4 commits into
mainfrom
eliottness/set-appsec-start-telemetry-error
Jun 16, 2025
Merged

internal/appsec: report appsec start error#3631
eliottness merged 4 commits into
mainfrom
eliottness/set-appsec-start-telemetry-error

Conversation

@eliottness

Copy link
Copy Markdown
Contributor

What does this PR do?

Report appsec as failed to start via telemetry

Motivation

Better appsec telemetry

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running golangci-lint run locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@eliottness
eliottness requested a review from a team as a code owner June 12, 2025 15:34
@pr-commenter

pr-commenter Bot commented Jun 12, 2025

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-06-16 09:10:18

Comparing candidate commit c2a6afa in PR branch eliottness/set-appsec-start-telemetry-error with baseline commit 381ae30 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@eliottness
eliottness enabled auto-merge (squash) June 13, 2025 14:52
@eliottness
eliottness merged commit 97cfb39 into main Jun 16, 2025
239 checks passed
@eliottness
eliottness deleted the eliottness/set-appsec-start-telemetry-error branch June 16, 2025 09:16
mtoffl01 pushed a commit that referenced this pull request Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants