Skip to content

contrib/gorilla/mux: fix orchestrion aspect#3630

Merged
rarguelloF merged 5 commits into
mainfrom
rarguelloF/fix-gorilla-mux-aspct
Jun 13, 2025
Merged

contrib/gorilla/mux: fix orchestrion aspect#3630
rarguelloF merged 5 commits into
mainfrom
rarguelloF/fix-gorilla-mux-aspct

Conversation

@rarguelloF

@rarguelloF rarguelloF commented Jun 12, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes contrib/gorilla/mux so it enforces go1.18, since it is injecting generics through the github.com/DataDog/dd-trace-go/v2/instrumentation/options package.

This issue has arised in one of the Orchestrion benchmarks that instruments traefik, which has a replace of gorilla/mux pointing to a fork of an old version that does not have a go.mod: https://github.com/traefik/traefik/blob/master/go.mod#L394

Additionally, updates the aspect to use the v2 instrumentation api instead of using internal packages.

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running golangci-lint run locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@github-actions github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label Jun 12, 2025
@rarguelloF rarguelloF changed the title contrib/gorilla/mux: use v2 instrumentation api in the orchestrion as… contrib/gorilla/mux: use v2 instrumentation api in the orchestrion aspect Jun 12, 2025
@pr-commenter

pr-commenter Bot commented Jun 12, 2025

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-06-13 13:00:24

Comparing candidate commit 0ab2ff4 in PR branch rarguelloF/fix-gorilla-mux-aspct with baseline commit 07c6077 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@rarguelloF
rarguelloF marked this pull request as ready for review June 12, 2025 12:56
@rarguelloF
rarguelloF requested review from a team as code owners June 12, 2025 12:56
@rarguelloF
rarguelloF enabled auto-merge (squash) June 13, 2025 12:44
@rarguelloF rarguelloF changed the title contrib/gorilla/mux: use v2 instrumentation api in the orchestrion aspect contrib/gorilla/mux: fix orchestrion aspect Jun 13, 2025
@rarguelloF
rarguelloF merged commit 06ecc76 into main Jun 13, 2025
220 checks passed
@rarguelloF
rarguelloF deleted the rarguelloF/fix-gorilla-mux-aspct branch June 13, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

apm:ecosystem contrib/* related feature requests or bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants