Skip to content

feat (internal/civisibility): Add test logs collection support#3624

Merged
tonyredondo merged 13 commits into
mainfrom
tony/test-optimization-add-output-support
Jun 13, 2025
Merged

feat (internal/civisibility): Add test logs collection support#3624
tonyredondo merged 13 commits into
mainfrom
tony/test-optimization-add-output-support

Conversation

@tonyredondo

Copy link
Copy Markdown
Member

What does this PR do?

This PR adds support for collecting all logs generated by testing.T from both t.common.output slice or the t.common.chatty chatty printer.

All logs extracted are sent to the backend and linked to the specific test as seen in the screenshot:

image

Motivation

We are lacking about context information from a test execution. By collecting the logs created by the test we get more information to show to the customer in case of failures.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running golangci-lint run locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@tonyredondo
tonyredondo requested a review from a team as a code owner June 12, 2025 07:52
@tonyredondo
tonyredondo requested a review from liashenko June 12, 2025 07:52
@tonyredondo tonyredondo self-assigned this Jun 12, 2025
@pr-commenter

pr-commenter Bot commented Jun 12, 2025

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-06-13 15:11:18

Comparing candidate commit 93a86d1 in PR branch tony/test-optimization-add-output-support with baseline commit 06ecc76 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 15 metrics, 0 unstable metrics.

@tonyredondo
tonyredondo merged commit a61135e into main Jun 13, 2025
218 checks passed
@tonyredondo
tonyredondo deleted the tony/test-optimization-add-output-support branch June 13, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants