Skip to content

feat(appsec): support WAF trace tagging rules#3619

Merged
RomainMuller merged 5 commits into
mainfrom
romain.marcadier/APPSEC-57565/waf.keep
Jun 11, 2025
Merged

feat(appsec): support WAF trace tagging rules#3619
RomainMuller merged 5 commits into
mainfrom
romain.marcadier/APPSEC-57565/waf.keep

Conversation

@RomainMuller

@RomainMuller RomainMuller commented Jun 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Honors the new Keep result from libddwaf by overriding the trace priority as appropriate.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running golangci-lint run locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@RomainMuller Graphite App

RomainMuller commented Jun 11, 2025

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@RomainMuller
RomainMuller marked this pull request as ready for review June 11, 2025 10:23
@RomainMuller
RomainMuller requested review from a team as code owners June 11, 2025 10:23
@pr-commenter

pr-commenter Bot commented Jun 11, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-06-11 14:24:47

Comparing candidate commit 597f26f in PR branch romain.marcadier/APPSEC-57565/waf.keep with baseline commit 25642e2 in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 8 metrics, 0 unstable metrics.

scenario:BenchmarkSetTagString-24

  • 🟥 execution_time [+3.532ns; +8.568ns] or [+3.116%; +7.558%]

@RamyElkest

RamyElkest commented Jun 11, 2025

Copy link
Copy Markdown
Contributor

We need to add the ASM_TRACE_TAGGING_RULES capability

@RomainMuller
RomainMuller requested a review from a team as a code owner June 11, 2025 12:01
@RomainMuller RomainMuller mentioned this pull request Jun 11, 2025
Merged
7 tasks
@RomainMuller
RomainMuller removed the request for review from a team June 11, 2025 14:23
@RomainMuller
RomainMuller enabled auto-merge (squash) June 11, 2025 14:23
@RomainMuller
RomainMuller merged commit f92a95e into main Jun 11, 2025
236 checks passed
@RomainMuller
RomainMuller deleted the romain.marcadier/APPSEC-57565/waf.keep branch June 11, 2025 14:40
mtoffl01 pushed a commit that referenced this pull request Jun 23, 2025
@RomainMuller @mtoffl01
feat(appsec): support WAF trace tagging rules (#3619)
478acfa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eliottness eliottness eliottness approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RomainMuller @RamyElkest @eliottness