Skip to content

internal/telemetry: make sure only backend known metrics are released#3614

Merged
eliottness merged 2 commits into
mainfrom
eliottness/only-known-metrics-on-main
Jun 16, 2025
Merged

internal/telemetry: make sure only backend known metrics are released#3614
eliottness merged 2 commits into
mainfrom
eliottness/only-known-metrics-on-main

Conversation

@eliottness

@eliottness eliottness commented Jun 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR adds a check in telemetry testing code to make sure we don't release metrics that would get refused by the backend

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running golangci-lint run locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@eliottness
eliottness requested review from a team as code owners June 10, 2025 13:59
@pr-commenter

pr-commenter Bot commented Jun 10, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-06-16 12:41:36

Comparing candidate commit 5194ae7 in PR branch eliottness/only-known-metrics-on-main with baseline commit 1ec2ff7 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@eliottness
eliottness force-pushed the eliottness/only-known-metrics-on-main branch from c62b8fa to 1645c90 Compare June 11, 2025 14:34
@eliottness
eliottness enabled auto-merge (squash) June 11, 2025 14:34
@eliottness
eliottness force-pushed the eliottness/only-known-metrics-on-main branch from 9f61a5d to 5194ae7 Compare June 16, 2025 12:29
@eliottness
eliottness merged commit 809550c into main Jun 16, 2025
218 checks passed
@eliottness
eliottness deleted the eliottness/only-known-metrics-on-main branch June 16, 2025 12:46
mtoffl01 pushed a commit that referenced this pull request Jun 23, 2025
@eliottness @mtoffl01
internal/telemetry: make sure only backend known metrics are released (…
4f12740 
…#3614)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RomainMuller RomainMuller RomainMuller approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eliottness @RomainMuller