Skip to content

ci: update deployment for docker images#3613

Merged
eliottness merged 8 commits into
mainfrom
flavien/fix-deployment-docker-images
Jul 9, 2025
Merged

ci: update deployment for docker images#3613
eliottness merged 8 commits into
mainfrom
flavien/fix-deployment-docker-images

Conversation

@e-n-0

@e-n-0 e-n-0 commented Jun 10, 2025

Copy link
Copy Markdown
Member

What does this PR do?

This PR changes multiple things:

Docker image releases

This PR refactored the way docker images (like service-extensions or request-mirror) are built.
The build and upload workflow is now a reusable component.

The docker images of the repo are now released at the same time as the tracer.

Service Extensions / External Processing in system tests

This PR build a service extension image based on the latest commit (all PRs) and run the EXTERNAL_PROCESSING system tests scenarios on that image.

Changes:

  • Move out the EXTERNAL_PROCESSING scenarios out of the system-tests job
  • Created a build step for the docker image (using the new refactored workflow component)
  • Created a new system-tests job only for the external processing (downloading the built image and run the selected scenarios on it)
  • On main, on each new commits, the service extensions docker image used for the system tests is uploaded to the registry with the dev tag (that will be later used by the system-tests repo to run the tests as Dev)

Motivation

  • Easier release of the docker images
  • We want to run continuously the system tests on the latest version of the service extension image. Currently it was only ran when the image was released (so after a tracer release).

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running golangci-lint run locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@e-n-0
e-n-0 requested review from a team as code owners June 10, 2025 13:38
@e-n-0
e-n-0 force-pushed the flavien/fix-deployment-docker-images branch from 9187738 to 65c5626 Compare June 10, 2025 13:38
Comment thread .github/workflows/docker-build-and-push.yml Outdated
@e-n-0 e-n-0 self-assigned this Jun 10, 2025
@e-n-0 e-n-0 added the ci label Jun 10, 2025
@pr-commenter

pr-commenter Bot commented Jun 10, 2025

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-07-09 14:01:19

Comparing candidate commit 10887a5 in PR branch flavien/fix-deployment-docker-images with baseline commit d92fd91 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@e-n-0
e-n-0 force-pushed the flavien/fix-deployment-docker-images branch from 65c5626 to aa9fd27 Compare June 10, 2025 14:10
Comment thread .github/workflows/docker-build-and-push.yml Outdated
Comment thread .github/workflows/docker-build-images.yml Outdated
@e-n-0
e-n-0 force-pushed the flavien/fix-deployment-docker-images branch 6 times, most recently from 28bc190 to 77944fd Compare June 13, 2025 09:23
Comment thread .github/workflows/reusable-docker-build-and-push.yml Outdated
@e-n-0
e-n-0 force-pushed the flavien/fix-deployment-docker-images branch 7 times, most recently from efe2575 to 92733f6 Compare June 13, 2025 14:25
@e-n-0
e-n-0 marked this pull request as draft June 13, 2025 14:27
@e-n-0
e-n-0 force-pushed the flavien/fix-deployment-docker-images branch 5 times, most recently from 6c8c4b7 to 04d3d11 Compare June 13, 2025 14:56
@e-n-0
e-n-0 force-pushed the flavien/fix-deployment-docker-images branch from ff3f962 to ce4a620 Compare June 13, 2025 15:39
@e-n-0
e-n-0 force-pushed the flavien/fix-deployment-docker-images branch from ce4a620 to 0ddb32e Compare June 13, 2025 15:49
@e-n-0
e-n-0 marked this pull request as ready for review June 13, 2025 15:56
@e-n-0
e-n-0 requested a review from eliottness June 16, 2025 12:33
Comment thread .github/workflows/docker-images-release.yml Outdated
@e-n-0
e-n-0 force-pushed the flavien/fix-deployment-docker-images branch 7 times, most recently from aa071d2 to 6cb2bd7 Compare July 7, 2025 12:50
@e-n-0
e-n-0 requested a review from eliottness July 7, 2025 12:53
Comment thread .github/workflows/docker-build-and-push.yml
Comment thread .github/workflows/docker-images-release.yml Outdated
@e-n-0
e-n-0 force-pushed the flavien/fix-deployment-docker-images branch from 1746547 to 10887a5 Compare July 9, 2025 13:48
@eliottness
eliottness enabled auto-merge (squash) July 9, 2025 13:55
@eliottness
eliottness merged commit 331e7e0 into main Jul 9, 2025
221 checks passed
@eliottness
eliottness deleted the flavien/fix-deployment-docker-images branch July 9, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants