Skip to content

contrib/julienschmidt/httprouter: add godoc links#3610

Merged
rarguelloF merged 1 commit into
DataDog:mainfrom
dolmen-go:contrib-httprouter-godoc-links
Jul 30, 2025
Merged

contrib/julienschmidt/httprouter: add godoc links#3610
rarguelloF merged 1 commit into
DataDog:mainfrom
dolmen-go:contrib-httprouter-godoc-links

Conversation

@dolmen

@dolmen dolmen commented Jun 10, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

Improve Go doc of package contrib/julienschmidt/httprouter by using godoc links.

Motivation

Improved readability of the documentation thanks to cross links.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running golangci-lint run locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

@dolmen
dolmen requested review from a team as code owners June 10, 2025 08:00
@dolmen
dolmen force-pushed the contrib-httprouter-godoc-links branch from dadfd56 to 13b445c Compare June 10, 2025 12:12
@kakkoyun
kakkoyun enabled auto-merge (squash) June 11, 2025 07:31
@kakkoyun
kakkoyun disabled auto-merge June 11, 2025 07:34
@kakkoyun
kakkoyun enabled auto-merge (squash) June 11, 2025 07:34
@kakkoyun

kakkoyun commented Jun 25, 2025

Copy link
Copy Markdown
Member

For context: https://go.dev/doc/comment#links

@rarguelloF
rarguelloF disabled auto-merge July 14, 2025 09:01
@rarguelloF
rarguelloF enabled auto-merge (squash) July 14, 2025 09:01
@rarguelloF

rarguelloF commented Jul 14, 2025

Copy link
Copy Markdown
Contributor

Hi @dolmen,

Thanks for the PR, we really appreciate your contribution!

Currently, this PR cannot be merged because of the new repository requirement (Commits need to be signed). So if possible, could you:

  • If you’re comfortable doing so, feel free to GPG-sign the commits yourself to comply with the repo’s commit policy.
  • Otherwise, please enable the “Allow edits from maintainers” option on this PR on your fork so we can sign the commits on your behalf.

Thanks!

@rarguelloF
rarguelloF disabled auto-merge July 18, 2025 09:41
@rarguelloF

rarguelloF commented Jul 18, 2025

Copy link
Copy Markdown
Contributor

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Jul 18, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-07-18 09:42:17 UTC ℹ️ Start processing command /merge

2025-07-18 09:42:26 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-07-18 09:43:18 UTC ⚠️ MergeQueue: This merge request was unqueued

[email protected] unqueued this merge request

@rarguelloF

rarguelloF commented Jul 18, 2025

Copy link
Copy Markdown
Contributor

/merge -c

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Jul 18, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-07-18 09:43:12 UTC ℹ️ Start processing command /merge -c

@rarguelloF
rarguelloF merged commit 0882a7d into DataDog:main Jul 30, 2025
103 of 104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kakkoyun kakkoyun kakkoyun approved these changes
@rarguelloF rarguelloF rarguelloF approved these changes

Assignees

No one assigned

Labels

mergequeue-status: removed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dolmen @kakkoyun @rarguelloF