contrib/hashicorp/vault: add godoc links#3609
Merged
Merged
Conversation
dolmen
force-pushed
the
contrib-vault-godoc
branch
from
June 10, 2025 07:39
3c956eb to
b1e5f2b
Compare
kakkoyun
approved these changes
Jun 10, 2025
kakkoyun
enabled auto-merge (squash)
June 10, 2025 08:22
auto-merge was automatically disabled
June 10, 2025 12:10
Head branch was pushed to by a user without write access
dolmen
force-pushed
the
contrib-vault-godoc
branch
from
June 10, 2025 12:10
b1e5f2b to
12aab99
Compare
kakkoyun
enabled auto-merge (squash)
June 11, 2025 07:34
rarguelloF
approved these changes
Jul 7, 2025
Contributor
|
Hi @dolmen, Thanks for the PR, we really appreciate your contribution! Currently, this PR cannot be merged because of the new repository requirement (Commits need to be signed). So if possible, could you:
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improve Go doc of package
contrib/hashicorp/vaultby using godoc links.Motivation
Improved readability of the documentation thanks to cross links.
Reviewer's Checklist
golangci-lint runlocally.