feat(profiler): show config in profile "Runtime Info" tab#3588
Merged
Conversation
kakkoyun
approved these changes
Jun 3, 2025
| "flush_on_exit": c.flushOnExit, | ||
| } | ||
| for _, tc := range telemetryConfiguration(c) { | ||
| info[tc.Name] = tc.Value |
nsrip-dd
approved these changes
Jun 3, 2025
nsrip-dd
left a comment
nsrip-dd
left a comment
Contributor
There was a problem hiding this comment.
Nice refactor! I tested this out with a toy program and confirmed that I see the info in the profiling UI, and the startup logs still look reasonable.
Keep everything the same, except for "enabled_profiles" which is replaced with "cpu_profile_enabled", "heap_profile_enabled", etc. because the telemetry client is using the latter values and there shouldn't be a strong reason for using a different approach in the startup log.
felixge
force-pushed
the
push-ksqlrsqrvxzl
branch
from
June 3, 2025 14:23
60b1e60 to
c762b18
Compare
felixge
enabled auto-merge (squash)
June 3, 2025 14:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Show the profiler config in the "Runtime Info" tab of the profiler viewer: Example
Can be tested with:
Motivation
This will help with debugging, especially internal usage.
Reviewer's Checklist
golangci-lint runlocally.Unsure? Have a question? Request a review!