Skip to content

fix (internal/civisibility): update the impacted tests algorithm to use only remote branches.#3584

Merged
tonyredondo merged 3 commits into
mainfrom
tony/update-impacted-tests-detection
Jun 3, 2025
Merged

fix (internal/civisibility): update the impacted tests algorithm to use only remote branches.#3584
tonyredondo merged 3 commits into
mainfrom
tony/update-impacted-tests-detection

Conversation

@tonyredondo

@tonyredondo tonyredondo commented Jun 2, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

This PR updates the Impacted Tests algorithm to use only remote branches.

JIRA: https://datadoghq.atlassian.net/browse/SDTEST-2111

Motivation

There's an update in the algorithm: https://datadoghq.atlassian.net/wiki/spaces/SDTEST/pages/4516480052/Impacted+tests+detection

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running golangci-lint run locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@tonyredondo tonyredondo self-assigned this Jun 2, 2025
@tonyredondo
tonyredondo requested review from a team as code owners June 2, 2025 14:29
@tonyredondo
tonyredondo enabled auto-merge (squash) June 2, 2025 14:48
@pr-commenter

pr-commenter Bot commented Jun 2, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-06-03 10:46:04

Comparing candidate commit 2459bc1 in PR branch tony/update-impacted-tests-detection with baseline commit df5976c in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 21 metrics, 0 unstable metrics.

@tonyredondo
tonyredondo merged commit 12ec839 into main Jun 3, 2025
@tonyredondo
tonyredondo deleted the tony/update-impacted-tests-detection branch June 3, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anmarchenko anmarchenko anmarchenko approved these changes
@daniel-mohedano daniel-mohedano Awaiting requested review from daniel-mohedano daniel-mohedano is a code owner automatically assigned from DataDog/ci-app-libraries

Assignees

@tonyredondo tonyredondo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tonyredondo @anmarchenko