Skip to content

profiler: add process tags to profiling payloads#3583

Merged
rarguelloF merged 2 commits into
mainfrom
rarguelloF/process-tags-profiling
Jun 4, 2025
Merged

profiler: add process tags to profiling payloads#3583
rarguelloF merged 2 commits into
mainfrom
rarguelloF/process-tags-profiling

Conversation

@rarguelloF

@rarguelloF rarguelloF commented Jun 2, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Followup of #3566

Adds ProcessTags to profiling payloads.

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running golangci-lint run locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@rarguelloF
rarguelloF marked this pull request as ready for review June 2, 2025 14:11
@rarguelloF
rarguelloF requested review from a team as code owners June 2, 2025 14:11
@rarguelloF
rarguelloF requested a review from amarziali June 2, 2025 14:11
nsrip-dd
nsrip-dd approved these changes Jun 4, 2025
View reviewed changes

@nsrip-dd nsrip-dd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. For posterity, this format has been discussed in the following internal docs: 1, 2.

@rarguelloF
rarguelloF enabled auto-merge (squash) June 4, 2025 14:17
@pr-commenter

pr-commenter Bot commented Jun 4, 2025

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-06-04 14:28:26

Comparing candidate commit 2a5e619 in PR branch rarguelloF/process-tags-profiling with baseline commit b7ba964 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 21 metrics, 0 unstable metrics.

@rarguelloF
rarguelloF merged commit f90e8ba into main Jun 4, 2025
189 checks passed
@rarguelloF
rarguelloF deleted the rarguelloF/process-tags-profiling branch June 4, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kakkoyun kakkoyun kakkoyun approved these changes
@amarziali amarziali amarziali approved these changes
@nsrip-dd nsrip-dd nsrip-dd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rarguelloF @kakkoyun @amarziali @nsrip-dd