Skip to content

internal/appsec: report libdl_present configuration#3582

Merged
eliottness merged 1 commit into
mainfrom
eliottness/detect-libdl
Jun 2, 2025
Merged

internal/appsec: report libdl_present configuration#3582
eliottness merged 1 commit into
mainfrom
eliottness/detect-libdl

Conversation

@eliottness

@eliottness eliottness commented Jun 2, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR uses 5 different ways report whenever we have libdl.so.2 on the system and would have been able to use it.

Motivation

Gauge the complexity of permanently adding CGO-like mechanisms to dd-trace-go.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running golangci-lint run locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@eliottness
eliottness marked this pull request as ready for review June 2, 2025 14:09
@eliottness
eliottness requested review from a team as code owners June 2, 2025 14:09
@eliottness
eliottness force-pushed the eliottness/detect-libdl branch from d564f23 to dde4c3b Compare June 2, 2025 14:10
@pr-commenter

pr-commenter Bot commented Jun 2, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-06-02 15:57:38

Comparing candidate commit 6c01727 in PR branch eliottness/detect-libdl with baseline commit bb65d84 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 21 metrics, 0 unstable metrics.

@eliottness
eliottness force-pushed the eliottness/detect-libdl branch from dde4c3b to ffd1afb Compare June 2, 2025 15:18
@eliottness
eliottness enabled auto-merge (squash) June 2, 2025 15:19
@eliottness
eliottness force-pushed the eliottness/detect-libdl branch from ffd1afb to 350678c Compare June 2, 2025 15:45
@eliottness
eliottness force-pushed the eliottness/detect-libdl branch from 350678c to 6c01727 Compare June 2, 2025 15:46
@eliottness
eliottness merged commit 466aad1 into main Jun 2, 2025
@eliottness
eliottness deleted the eliottness/detect-libdl branch June 2, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RomainMuller RomainMuller RomainMuller approved these changes

Assignees

No one assigned

Labels

appsec

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eliottness @RomainMuller