ddtrace/tracer: add process tags to client stats payload#3580
Merged
Conversation
github-actions
Bot
added
the
apm:ecosystem
rarguelloF
changed the title
rarguelloF
marked this pull request as ready for review
June 2, 2025 13:54
BenchmarksBenchmark execution time: 2025-06-03 13:05:53 Comparing candidate commit 6a2c155 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 21 metrics, 0 unstable metrics. |
rarguelloF
changed the title
amarziali
approved these changes
Jun 2, 2025
kakkoyun
approved these changes
Jun 3, 2025
| @@ -233,6 +234,7 @@ func (c *concentrator) flushAndSend(timenow time.Time, includeCurrent bool) { | |||
| // Given we use a constant PayloadAggregationKey there should only ever be 1 of these, but to be forward | |||
| // compatible in case this ever changes we can just iterate through all of them. | |||
| for _, csp := range csps { | |||
| csp.ProcessTags = processtags.GlobalTags().String() | |||
| @@ -129,6 +131,41 @@ func TestConcentrator(t *testing.T) { | |||
| c.Stop() | |||
| assert.NotEmpty(t, transport.Stats()) | |||
| }) | |||
|
|
|||
| t.Run("processTagsEnabled", func(t *testing.T) { | |||
rarguelloF
enabled auto-merge (squash)
June 3, 2025 12:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Followup of #3566
Adds ProcessTags to client stats payloads.
Needed to upgrade
github.com/DataDog/datadog-agent/pkg/prototov0.66.0, where theProcessTagsfield has been added togithub.com/DataDog/datadog-agent/pkg/proto/pbgo/trace.ClientStatsPayload.Motivation
Reviewer's Checklist
golangci-lint runlocally.Unsure? Have a question? Request a review!