Skip to content

feat(appsec): contrib/gin-gonic/gin semi-transparent body analysis#3579

Merged
RomainMuller merged 18 commits into
mainfrom
romain.marcadier/APPSEC-57835/http-response-body-gin
Jun 11, 2025
Merged

feat(appsec): contrib/gin-gonic/gin semi-transparent body analysis#3579
RomainMuller merged 18 commits into
mainfrom
romain.marcadier/APPSEC-57835/http-response-body-gin

Conversation

@RomainMuller

@RomainMuller RomainMuller commented Jun 2, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

Collect HTTP response body information in the echo contrib via dedicated helpers and add Orchestrion configuration.

Motivation

Provides improved coverage for AAP features such as the API catalog response schemas & data classification.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running golangci-lint run locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@github-actions github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label Jun 2, 2025
@pr-commenter

pr-commenter Bot commented Jun 2, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-06-11 07:55:34

Comparing candidate commit 918edf3 in PR branch romain.marcadier/APPSEC-57835/http-response-body-gin with baseline commit 216c23a in branch main.

Found 3 performance improvements and 3 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

scenario:BenchmarkGraphQL/version_dyngo/scenario_basic-24

  • 🟥 allocations [+52; +52] or [+2.723%; +2.723%]
  • 🟩 execution_time [-27.608µs; -24.337µs] or [-5.143%; -4.534%]

scenario:BenchmarkGraphQL/version_dyngo/scenario_embedded-variable-24

  • 🟥 allocations [+53; +54] or [+2.116%; +2.132%]
  • 🟩 execution_time [-26.227µs; -22.636µs] or [-3.810%; -3.289%]

scenario:BenchmarkGraphQL/version_dyngo/scenario_with-default-parameter-24

  • 🟥 allocations [+52; +52] or [+2.738%; +2.738%]
  • 🟩 execution_time [-26.375µs; -23.516µs] or [-4.911%; -4.379%]

@RomainMuller RomainMuller mentioned this pull request Jun 2, 2025
Merged
7 tasks
@RomainMuller
RomainMuller force-pushed the romain.marcadier/APPSEC-57836/http-response-body-echo branch from 998d77d to 39ae9eb Compare June 2, 2025 14:40
@RomainMuller
RomainMuller force-pushed the romain.marcadier/APPSEC-57835/http-response-body-gin branch from a64933d to 0a4414d Compare June 2, 2025 14:40
@RomainMuller Graphite App

RomainMuller commented Jun 2, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@RomainMuller RomainMuller mentioned this pull request Jun 2, 2025
Merged
7 tasks
@RomainMuller
RomainMuller marked this pull request as ready for review June 2, 2025 14:42
@RomainMuller
RomainMuller requested review from a team as code owners June 2, 2025 14:42
eliottness
eliottness requested changes Jun 3, 2025
View reviewed changes
Comment thread contrib/gin-gonic/gin/appsec.go
Comment thread contrib/gin-gonic/gin/orchestrion.yml Outdated
@RomainMuller
RomainMuller force-pushed the romain.marcadier/APPSEC-57836/http-response-body-echo branch from c3b7c4c to 1d762c1 Compare June 3, 2025 15:54
@RomainMuller
RomainMuller requested a review from a team as a code owner June 3, 2025 15:54
@RomainMuller
RomainMuller force-pushed the romain.marcadier/APPSEC-57835/http-response-body-gin branch from 0a4414d to 7d7efc0 Compare June 3, 2025 15:56
Base automatically changed from romain.marcadier/APPSEC-57836/http-response-body-echo to main June 6, 2025 12:45
@RomainMuller
RomainMuller force-pushed the romain.marcadier/APPSEC-57835/http-response-body-gin branch from 1ce7117 to 4dca655 Compare June 10, 2025 15:33
@RomainMuller
RomainMuller enabled auto-merge (squash) June 10, 2025 15:52
@RomainMuller
RomainMuller requested a review from eliottness June 10, 2025 15:53
eliottness
eliottness reviewed Jun 11, 2025
View reviewed changes
Comment thread contrib/gin-gonic/gin/appsec.go Outdated
Comment thread contrib/gin-gonic/gin/orchestrion.yml Outdated
@RomainMuller
RomainMuller requested a review from eliottness June 11, 2025 07:49
@RomainMuller
RomainMuller merged commit ddfb6c4 into main Jun 11, 2025
236 of 326 checks passed
@RomainMuller
RomainMuller deleted the romain.marcadier/APPSEC-57835/http-response-body-gin branch June 11, 2025 08:41
mtoffl01 pushed a commit that referenced this pull request Jun 23, 2025
@RomainMuller @mtoffl01
feat(appsec): contrib/gin-gonic/gin semi-transparent body analysis (#…
cfacaff 
…3579)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kakkoyun kakkoyun kakkoyun approved these changes
@eliottness eliottness eliottness approved these changes

Assignees

No one assigned

Labels

apm:ecosystem contrib/* related feature requests or bugs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RomainMuller @kakkoyun @eliottness