feat: add process tags to tracing payloads#3566
Merged
Merged
Conversation
rarguelloF
marked this pull request as ready for review
May 29, 2025 14:10
darccio
reviewed
May 29, 2025
BenchmarksBenchmark execution time: 2025-06-02 12:58:34 Comparing candidate commit 9c8a429 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 21 metrics, 0 unstable metrics. |
darccio
approved these changes
May 29, 2025
amarziali
reviewed
Jun 2, 2025
amarziali
reviewed
Jun 2, 2025
amarziali
approved these changes
Jun 2, 2025
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
Added to the queue but the mergequeue is not enabled for now.
This PR is rejected because it was updated |
dd-devflow
Bot
added
mergequeue-status: rejected
and removed
mergequeue-status: queued
labels
This was referenced Jun 2, 2025
7 tasks
7 tasks
felixge
reviewed
Jul 31, 2025
| keyPeerServiceRemappedFrom = "_dd.peer.service.remapped_from" | ||
| // keyBaseService contains the globally configured tracer service name. It is only set for spans that override it. | ||
| keyBaseService = "_dd.base_service" | ||
| // keyProcessTags contains a list of process tags to indentify the service. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a new
_dd.tags.processtrace-level tag (equivalent to the following DataDog/dd-trace-java#8698), which will allow users to rename their services.The initially collected tags for Go are:
But these could be extended in the future, and might be collected and added by some contribs (e.g. the grpc service name or similar).
By default the collection of these tags is disabled, and is enabled using the environment variable:
DD_EXPERIMENTAL_PROPAGATE_PROCESS_TAGS_ENABLED.There will be a number of follow-up PRs adding this data to the payloads for:
Motivation
Reviewer's Checklist
golangci-lint runlocally.Unsure? Have a question? Request a review!