chore(ddtrace/tracer): remove unused exported functions#3563
Merged
Conversation
Member
Author
|
Broken CI because of unrelated issue with |
…er functions from public API
darccio
force-pushed
the
dario.castane/hide-chunks
branch
from
May 29, 2025 13:40
af84365 to
08ae156
Compare
darccio
added a commit
that referenced
this pull request
May 29, 2025
Merged
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
These functions are exported and not used in our repository. They were introduced during
v2development, and have been deemed as not needed.Chunk was exported in #2408. Its fields were unexported later, so it's an opaque type that needs to be exported for
mocktracer.Once we remove/improve the
mocktracer, we'll be able to unexport it again. As it's opaque and there isn't public API using it, it won't be a breaking change for external users.Motivation
Reduce API.
Reviewer's Checklist
golangci-lint runlocally.Unsure? Have a question? Request a review!