Skip to content

chore(ddtrace/tracer): remove unused exported functions#3563

Merged
darccio merged 4 commits into
mainfrom
dario.castane/hide-chunks
May 29, 2025
Merged

chore(ddtrace/tracer): remove unused exported functions#3563
darccio merged 4 commits into
mainfrom
dario.castane/hide-chunks

Conversation

@darccio

@darccio darccio commented May 29, 2025

Copy link
Copy Markdown
Member

What does this PR do?

These functions are exported and not used in our repository. They were introduced during v2 development, and have been deemed as not needed.

Chunk was exported in #2408. Its fields were unexported later, so it's an opaque type that needs to be exported for mocktracer.

Once we remove/improve the mocktracer, we'll be able to unexport it again. As it's opaque and there isn't public API using it, it won't be a breaking change for external users.

Motivation

Reduce API.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running golangci-lint run locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@darccio
darccio requested a review from a team as a code owner May 29, 2025 09:24
@darccio

darccio commented May 29, 2025

Copy link
Copy Markdown
Member Author

Broken CI because of unrelated issue with github.com/garyburd/redigo.

@pr-commenter

pr-commenter Bot commented May 29, 2025

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-05-29 13:50:47

Comparing candidate commit 08ae156 in PR branch dario.castane/hide-chunks with baseline commit ea489fb in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 21 metrics, 0 unstable metrics.

@darccio
darccio force-pushed the dario.castane/hide-chunks branch from af84365 to 08ae156 Compare May 29, 2025 13:40
@darccio
darccio merged commit 8d232fd into main May 29, 2025
@darccio
darccio deleted the dario.castane/hide-chunks branch May 29, 2025 13:59

@kakkoyun kakkoyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants