Skip to content

refactor(ddtrace/tracer): remove Submit method from Tracer interface#3561

Merged
darccio merged 2 commits into
mainfrom
dario.castane/remove-submit-tracer-ifc
May 28, 2025
Merged

refactor(ddtrace/tracer): remove Submit method from Tracer interface#3561
darccio merged 2 commits into
mainfrom
dario.castane/remove-submit-tracer-ifc

Conversation

@darccio

@darccio darccio commented May 28, 2025

Copy link
Copy Markdown
Member

What does this PR do?

Removes ddtrace/tracer/Tracer.Submit because it's not longer needed.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running golangci-lint run locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@darccio
darccio requested a review from a team as a code owner May 28, 2025 10:16
@darccio

darccio commented May 28, 2025

Copy link
Copy Markdown
Member Author

@kakkoyun The public API change is needed. It was added during v2 development, but it is no longer needed, and it wasn't present on v1. cc @knusbaum

It comes from #2633.

@pr-commenter

pr-commenter Bot commented May 28, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-05-28 14:53:58

Comparing candidate commit a01c311 in PR branch dario.castane/remove-submit-tracer-ifc with baseline commit 0fcee3d in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 21 metrics, 0 unstable metrics.

@kakkoyun

kakkoyun commented May 28, 2025

Copy link
Copy Markdown
Member

@kakkoyun The public API change is needed. It was added during v2 development, but it is no longer needed, and it wasn't present on v1. cc @knusbaum

It comes from #2633.

Less is more 😊 Let's make sure the api.txt is up-to-date. Otherwise, CI will fail.

@darccio
darccio enabled auto-merge (squash) May 28, 2025 14:44
@darccio
darccio merged commit c05e36c into main May 28, 2025
@darccio
darccio deleted the dario.castane/remove-submit-tracer-ifc branch May 28, 2025 15:00
darccio added a commit that referenced this pull request May 28, 2025
@darccio
refactor(ddtrace/tracer): remove Submit method from Tracer interface (#…
3fc374e 
…3561)
@kakkoyun kakkoyun mentioned this pull request Jun 16, 2025
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kakkoyun kakkoyun kakkoyun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@darccio @kakkoyun