orchestrion: don't trace the tracer even if tracer.Start(tracer.WithHTTPClient(...)) is called#3559
Merged
Merged
Conversation
github-actions
Bot
added
the
apm:ecosystem
BenchmarksBenchmark execution time: 2025-06-03 09:49:59 Comparing candidate commit a226a9b in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 21 metrics, 0 unstable metrics. |
eliottness
force-pushed
the
eliottness/telemetry-traced
branch
5 times, most recently
from
May 30, 2025 12:36
72c0b8c to
dc6223d
Compare
Signed-off-by: Eliott Bouhana <[email protected]>
…on is used because it woult create a span bomb Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
eliottness
force-pushed
the
eliottness/telemetry-traced
branch
from
May 30, 2025 12:56
dc6223d to
e8d8e42
Compare
eliottness
changed the title
eliottness
changed the title
eliottness
commented
May 30, 2025
| copyClient := *config.HTTPClient | ||
| config.HTTPClient = ©Client | ||
| config.HTTPClient.Timeout = 5 * time.Second | ||
| log.Debug("telemetry/writer: client timeout was higher than 5 seconds, clamping it to 5 seconds") |
Contributor
Author
There was a problem hiding this comment.
I realized this is happening everywhere so I removed the debug log
eliottness
commented
May 30, 2025
Comment on lines
-33
to
-34
| // | ||
| //orchestrion:ignore |
Contributor
Author
There was a problem hiding this comment.
this is so that orchestrion can actually add the DD_tracer_internal: true field here
darccio
reviewed
Jun 2, 2025
Co-authored-by: Dario Castañé <[email protected]>
eliottness
enabled auto-merge (squash)
June 2, 2025 11:41
rarguelloF
approved these changes
Jun 3, 2025
darccio
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR was originally made to fix an issue where traces where generated on orchestrion apps from the calls made inside dd-trace-go's telemetry client. Which later revealed that any part of the tracer was susceptible to auto-tracing if a call to
tracer.Startis made using the optionWithHTTPClientThis PR also add tests at the orchestrion testing framework harness level to make sure this does not happen anymore.
Reviewer's Checklist
golangci-lint runlocally.Unsure? Have a question? Request a review!