fix(ddtrace/tracer): fix UDS handling in WithAgentURL (#3553)#3554
Merged
Conversation
kakkoyun
reviewed
May 27, 2025
nsrip-dd
approved these changes
May 27, 2025
mtoffl01
approved these changes
May 27, 2025
mtoffl01
left a comment
mtoffl01
left a comment
Contributor
There was a problem hiding this comment.
LGTM, some suggestions -
- UnixURL may be a good alternative name to UDSURL
- Although unlikely in the real world, it might be good to add a test case when path is nil?
- IMO you might as well migrate all the
// TODO(darccio): use internal.UDSURL insteadto actually use the new helper function rather than leaving it as a TODO. I would understand if this is just a safety measure to enable v2 release, though
Member
Author
|
I agree with the naming suggestion, I wasn't inspired at the moment. Just a few comments:
That shouldn't be possible,
It is a safety measure to avoid introducing side effects for v2 release. |
darccio
enabled auto-merge (squash)
May 28, 2025 07:50
darccio
added a commit
that referenced
this pull request
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes how
WithAgentURLhandles Unix Data Sockets paths. It creates a helper function and tags some places where it could be used.Motivation
Fix #3553
Reviewer's Checklist
golangci-lint runlocally.Unsure? Have a question? Request a review!