Skip to content

fix: revert unexpected changes from v1->v2#3549

Merged
darccio merged 1 commit into
mainfrom
rarguelloF/fix-v2-changes
May 26, 2025
Merged

fix: revert unexpected changes from v1->v2#3549
darccio merged 1 commit into
mainfrom
rarguelloF/fix-v2-changes

Conversation

@rarguelloF

@rarguelloF rarguelloF commented May 26, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

Revert unexpected changes from v1 -> v2:

  • valkey-go default service name changed from valkey.client to unset.
  • segmentio/kafka-go changed component name from segmentio/kafka.go.v0 to segmentio/kafka-go

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running golangci-lint run locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@rarguelloF
rarguelloF requested review from a team as code owners May 26, 2025 15:25
@github-actions github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label May 26, 2025
@pr-commenter

pr-commenter Bot commented May 26, 2025

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-05-26 15:33:51

Comparing candidate commit f02e8d8 in PR branch rarguelloF/fix-v2-changes with baseline commit 8cabacc in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 21 metrics, 0 unstable metrics.

@darccio
darccio merged commit 31f6d0d into main May 26, 2025
@darccio
darccio deleted the rarguelloF/fix-v2-changes branch May 26, 2025 15:45
darccio pushed a commit that referenced this pull request May 26, 2025
@rarguelloF @darccio
fix: revert unexpected changes from v1->v2 (#3549)
3cd7110
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darccio darccio darccio approved these changes

Assignees

No one assigned

Labels

apm:ecosystem contrib/* related feature requests or bugs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rarguelloF @darccio