[APM] Enable stats computation by default#3548
Merged
Merged
Conversation
Changed default value of DD_TRACE_STATS_COMPUTATION_ENABLED from false to true. Client-Side Stats will be enabled by default on dd-trace-go. This feature has been tested on internal production systems, and is now ready to be on by default.
BenchmarksBenchmark execution time: 2025-06-16 08:05:48 Comparing candidate commit aea9208 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics. |
kakkoyun
approved these changes
May 27, 2025
7 tasks
darccio
approved these changes
Jun 16, 2025
mtoffl01
pushed a commit
that referenced
this pull request
Jun 23, 2025
Co-authored-by: Benjamin De Bernardi <[email protected]>
jchrostek-dd
added a commit
to DataDog/datadog-lambda-go
that referenced
this pull request
Apr 15, 2026
…head in Lambda Stats computation was enabled by default in dd-trace-go v2.1.0 (DataDog/dd-trace-go#3548). When extension v91+ advertises /v0.6/stats support in its /info response, tracer.Flush() makes a synchronous HTTP POST to http://127.0.0.1:8126/v0.6/stats before returning, adding 33-59ms per warm invocation. This fix disables stats computation at the tracer level so it is never posted from Lambda, mirroring the identical fix already applied to the dd-trace-go contrib Lambda wrapper in DataDog/dd-trace-go#4471 (APMSVLS-389). Resolves: SLES-2790
jchrostek-dd
added a commit
to DataDog/datadog-lambda-go
that referenced
this pull request
Apr 20, 2026
…head in Lambda (#244) Stats computation was enabled by default in dd-trace-go v2.1.0 (DataDog/dd-trace-go#3548). When extension v91+ advertises /v0.6/stats support in its /info response, tracer.Flush() makes a synchronous HTTP POST to http://127.0.0.1:8126/v0.6/stats before returning, adding 33-59ms per warm invocation. This fix disables stats computation at the tracer level so it is never posted from Lambda, mirroring the identical fix already applied to the dd-trace-go contrib Lambda wrapper in DataDog/dd-trace-go#4471 (APMSVLS-389). Resolves: SLES-2790
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changed default value of DD_TRACE_STATS_COMPUTATION_ENABLED from false to true.
Client-Side Stats will be enabled by default on dd-trace-go. This feature has been tested on internal production systems, and is now ready to be on by default.
Motivation
https://docs.google.com/document/d/1N425X-VWaCqJ8bpwoOJ0NnZgLbde-My_KbNzQeAuOWg/edit?tab=t.0#heading=h.8d3o7vtyu1y1
Reviewer's Checklist
golangci-lint runlocally.Unsure? Have a question? Request a review!