Skip to content

fix: graphql default service name#3547

Merged
darccio merged 2 commits into
mainfrom
rarguelloF/fix-graphql-default-service
May 26, 2025
Merged

fix: graphql default service name#3547
darccio merged 2 commits into
mainfrom
rarguelloF/fix-graphql-default-service

Conversation

@rarguelloF

@rarguelloF rarguelloF commented May 26, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Fix unintended change in default service name for graph-gophers/graphql-go and graphql-go/graphql (used to be graphql.server in v1, not graphql).

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running golangci-lint run locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@github-actions github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label May 26, 2025
@pr-commenter

pr-commenter Bot commented May 26, 2025

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-05-26 13:24:15

Comparing candidate commit 6c922a5 in PR branch rarguelloF/fix-graphql-default-service with baseline commit 04e29ad in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 21 metrics, 0 unstable metrics.

kakkoyun
kakkoyun reviewed May 26, 2025
View reviewed changes
Comment thread contrib/graphql-go/graphql/graphql.go
// Copyright 2016 Datadog, Inc.

package graphql // import "github.com/DataDog/dd-trace-go/contrib/graph-go/graphql/v2"
package graphql // import "github.com/DataDog/dd-trace-go/contrib/graphql-go/graphql/v2"

@kakkoyun kakkoyun May 26, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we have a typo in the package name that we need to fix?

@darccio darccio May 26, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's only in the import URL from the comment.

@rarguelloF
rarguelloF marked this pull request as ready for review May 26, 2025 13:34
@rarguelloF
rarguelloF requested review from a team as code owners May 26, 2025 13:34
kakkoyun
kakkoyun approved these changes May 26, 2025
View reviewed changes

@kakkoyun kakkoyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Nothing stands out.

Thanks for the fix.

Comment thread instrumentation/internal/namingschematest/graphgophers_graphql_test.go
"github.com/stretchr/testify/require"

grahqltrace "github.com/DataDog/dd-trace-go/contrib/graph-gophers/graphql-go/v2"
graphqltrace "github.com/DataDog/dd-trace-go/contrib/graph-gophers/graphql-go/v2"

@kakkoyun kakkoyun May 26, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the same typo issue above.

@darccio darccio May 26, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, true.

The contrib URL is correct, it refers to github.com/graph-gophers/graphql-go.

@darccio
darccio merged commit 8cabacc into main May 26, 2025
@darccio
darccio deleted the rarguelloF/fix-graphql-default-service branch May 26, 2025 13:51
darccio pushed a commit that referenced this pull request May 26, 2025
@rarguelloF @darccio
fix: graphql default service name (#3547)
760da40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darccio darccio darccio approved these changes
@kakkoyun kakkoyun kakkoyun approved these changes

Assignees

No one assigned

Labels

apm:ecosystem contrib/* related feature requests or bugs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rarguelloF @darccio @kakkoyun