feat(contrib/net/http): new orchestrion http ResourceNamer with quantization#3545
Merged
dd-mergequeue[bot] merged 2 commits intoAug 21, 2025
Conversation
github-actions
Bot
added
the
apm:ecosystem
genesor
changed the title
kakkoyun
approved these changes
May 26, 2025
BenchmarksBenchmark execution time: 2025-08-19 14:08:29 Comparing candidate commit 08b4546 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics. |
genesor
marked this pull request as draft
May 26, 2025 11:49
genesor
marked this pull request as ready for review
May 27, 2025 13:33
genesor
force-pushed
the
ben.db/APMAPI-1418-change-orchestrion-http-client-resource-namer
branch
2 times, most recently
from
August 14, 2025 19:14
67d52ff to
1dff235
Compare
genesor
marked this pull request as draft
August 19, 2025 08:58
genesor
force-pushed
the
ben.db/APMAPI-1418-change-orchestrion-http-client-resource-namer
branch
from
August 19, 2025 13:47
1dff235 to
2e29629
Compare
genesor
changed the title
…lient-resource-namer
genesor
marked this pull request as ready for review
August 19, 2025 14:25
RomainMuller
approved these changes
Aug 21, 2025
rarguelloF
approved these changes
Aug 21, 2025
rarguelloF
approved these changes
Aug 21, 2025
Member
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
dd-devflow
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
dd-mergequeue
Bot
deleted the
ben.db/APMAPI-1418-change-orchestrion-http-client-resource-namer
branch
August 21, 2025 14:55
dd-devflow
Bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Leverage the newly introduced Quantizer in the Orchestrion HTTP client to have generic looking resource names in spans.
DD_TRACE_HTTP_CLIENT_RESOURCE_NAME_QUANTIZE&DD_TRACE_HTTP_HANDLER_RESOURCE_NAME_QUANTIZEnow allows users to have quantization applied to the URL when using orchestrion.Motivation
We had a question from an orchestrion user asking us how they could customize the resource name. It is not currently possible with orchestrion to customize the
RoundTripperConfigso providing users with a better ResourceNamer would makes things a bit better.GET /v4/api/projects/1234/repository/files/my-file=>GET /v4/api/projects/*/repository/files/*Reviewer's Checklist
golangci-lint runlocally.Unsure? Have a question? Request a review!