fix (internal/civisibility): use internal code coverage api to get the total percentage.#3540
Merged
Merged
Conversation
…e total percentage.
BenchmarksBenchmark execution time: 2025-05-23 13:13:28 Comparing candidate commit 40a7676 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 21 metrics, 0 unstable metrics. |
anmarchenko
approved these changes
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR enables the internal api used to get the global code coverage value on Test Impact Analysis scenario to a normal code coverage scenario.
Motivation
This Go
testing.Coverage()api is returning a different percentage from the one reported in the stdout. This issue started when the new code coverage algorithm started to be the default algorithm.See: golang/go#62212
Example:
By switching to our internal api (the internal api uses the same mechanism as the stdout format)
Reviewer's Checklist
golangci-lint runlocally.Unsure? Have a question? Request a review!