fix(internal/version): Check status of build info to avoid panic if not there.#3538
Merged
Conversation
arguile-
changed the title
Member
|
Thanks for the PR, @arguile-! In our tests in environments using Bazel this issue didn't raise. We agree that this fix is good for cases where debug info is not present. |
darccio
reviewed
May 21, 2025
darccio
approved these changes
May 21, 2025
darccio
pushed a commit
that referenced
this pull request
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
internal/version: check debug.ReadBuildInfo status to avoid panic
The status of the
debug.ReadBuildInfowas previously silently ignored which caused a panic at runtime for binaries that don't support it. Build systems like Bazel do not add this information.No tests were added as the
FindV1Versionis not currently tested anddebug.ReadBuildInfois not easy to fake. Changes out of scope of this fix would be need to support that.