feat (internal/civisibility): Add CIVisibility test event global hook#3531
Merged
Conversation
tonyredondo
force-pushed
the
tony/civisibility-event-hook
branch
from
May 19, 2025 08:39
68a876b to
f2250d3
Compare
BenchmarksBenchmark execution time: 2025-05-20 14:47:45 Comparing candidate commit d366a59 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 1 unstable metrics. |
tonyredondo
marked this pull request as ready for review
May 19, 2025 13:11
vitor-de-araujo
approved these changes
May 19, 2025
darccio
requested changes
May 20, 2025
Co-authored-by: Dario Castañé <[email protected]>
darccio
approved these changes
May 20, 2025
tonyredondo
enabled auto-merge (squash)
May 20, 2025 14:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR enables support for adding a hook to the test events in CI Visibility.
To enable it, we need to call the hook using a linkname because we don't want to expose it to customers yet (we are going to use internally in some repos).
Motivation
There's an internal case where a subtest should be tagged after a parent test has finished so we need to have a way to get all the tests generated by the library before closing them and send them to the backend.
Note: By setting the hook we are actively delaying all the finish() calls to the underlying span, so memory increases are expected and another reason to not make this available in the public api. If we don't set a hook we keep the same current behaviour, closing the span after the test finishes.
Reviewer's Checklist
golangci-lint runlocally.Unsure? Have a question? Request a review!