Skip to content

chore: test benchmarking platform#3530

Closed
felixge wants to merge 1 commit into
mainfrom
push-lrnnnmupnkmt
Closed

chore: test benchmarking platform#3530
felixge wants to merge 1 commit into
mainfrom
push-lrnnnmupnkmt

Conversation

@felixge

@felixge felixge commented May 18, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Benchmarking platform seems to produce false positives frequently these
days. I'm wondering if that can be reproduced by creating a PR that just
adds a new attempt file to the repository that just contains some
text.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running golangci-lint run locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

@pr-commenter

pr-commenter Bot commented May 18, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-05-19 08:31:30

Comparing candidate commit 2ef3592 in PR branch push-lrnnnmupnkmt with baseline commit 9eb8069 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 1 unstable metrics.

@felixge
felixge force-pushed the push-lrnnnmupnkmt branch 5 times, most recently from 26baef5 to 065d6b4 Compare May 19, 2025 07:29
@felixge
chore: test benchmarking platform
2ef3592 
Benchmarking platform seems to produce false positives frequently these
days. I'm wondering if that can be reproduced by creating a PR that just
adds a new `attempt` file to the repository that just contains some
text.
@felixge
felixge force-pushed the push-lrnnnmupnkmt branch from 065d6b4 to 2ef3592 Compare May 19, 2025 08:01
@felixge felixge mentioned this pull request May 19, 2025
Merged
7 tasks
@felixge felixge closed this Jul 20, 2025
@felixge
felixge deleted the push-lrnnnmupnkmt branch October 23, 2025 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@felixge