Skip to content

contrib/aws/aws-sdk-go-v2/aws: Fix dynamodb service inference#3528

Merged
rarguelloF merged 3 commits into
DataDog:mainfrom
LamineKouissi:fix-dynamodb-service-inference
May 21, 2025
Merged

contrib/aws/aws-sdk-go-v2/aws: Fix dynamodb service inference#3528
rarguelloF merged 3 commits into
DataDog:mainfrom
LamineKouissi:fix-dynamodb-service-inference

Conversation

@LamineKouissi

Copy link
Copy Markdown
Contributor

What does this PR do?

When a resource name (for example, a DynamoDB table) resolves to an empty string, we skip emitting that tag. This prevents empty‐value overrides and lets Datadog correctly apply its inferred‐service precedence—peer.aws.dynamodb.table > peer.hostname > peer.db.system—without being short‐circuited by blank tags

Motivation

Fixes #3096

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running golangci-lint run locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

@LamineKouissi
LamineKouissi requested review from a team as code owners May 16, 2025 21:27
@LamineKouissi LamineKouissi changed the title Fix dynamodb service inference contrib/aws/aws-sdk-go-v2/aws: Fix dynamodb service inference May 16, 2025
@LamineKouissi

Copy link
Copy Markdown
Contributor Author

Hi @kakkoyun @darccio @rarguelloF
Could you please let me know if any changes are needed? If everything looks good, I’d appreciate if you merge it.

@rarguelloF
rarguelloF merged commit 5a963b0 into DataDog:main May 21, 2025
@rarguelloF

Copy link
Copy Markdown
Contributor

Thanks for the fix! @LamineKouissi

@LamineKouissi

Copy link
Copy Markdown
Contributor Author

It’s my pleasure @rarguelloF

@LamineKouissi
LamineKouissi deleted the fix-dynamodb-service-inference branch May 24, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Dynamo Inferred Service only populated for Query operation

3 participants