Skip to content

fix (internal/civisibility): Fix environment variable parsing.#3527

Merged
tonyredondo merged 1 commit into
mainfrom
tony/civisibility-fix-env-var-parsing
May 19, 2025
Merged

fix (internal/civisibility): Fix environment variable parsing.#3527
tonyredondo merged 1 commit into
mainfrom
tony/civisibility-fix-env-var-parsing

Conversation

@tonyredondo

Copy link
Copy Markdown
Member

What does this PR do?

This PR fixes the environment variable parsing over a auto instrumentation provider environment variable.

Motivation

image

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running golangci-lint run locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@tonyredondo
tonyredondo requested review from a team as code owners May 16, 2025 13:05
@tonyredondo tonyredondo self-assigned this May 16, 2025
@pr-commenter

pr-commenter Bot commented May 16, 2025

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-05-16 13:33:34

Comparing candidate commit f61d4b7 in PR branch tony/civisibility-fix-env-var-parsing with baseline commit 9eb8069 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 1 unstable metrics.

@tonyredondo
tonyredondo merged commit 92fedf3 into main May 19, 2025
@tonyredondo
tonyredondo deleted the tony/civisibility-fix-env-var-parsing branch May 19, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants