feat (internal/civisibility): Add missing provider's environment variables.#3514
Merged
tonyredondo merged 5 commits intoMay 12, 2025
Merged
Conversation
Datadog Summary✅ Code Quality ✅ Code Security ✅ Dependencies Was this helpful? Give us feedback! |
daniel-mohedano
approved these changes
May 12, 2025
kakkoyun
approved these changes
May 12, 2025
…ronment-variables
tonyredondo
deleted the
tony/civisibility-add-missing-providers-environment-variables
branch
May 12, 2025 10:41
anmarchenko
reviewed
May 12, 2025
| tags[constants.CIJobURL] = os.Getenv("TRAVIS_JOB_WEB_URL") | ||
| tags[constants.GitCommitMessage] = os.Getenv("TRAVIS_COMMIT_MESSAGE") | ||
|
|
||
| tags[constants.GitHeadCommit] = os.Getenv("TRAVIS_PULL_REQUEST_SHA") |
Member
There was a problem hiding this comment.
from travis docs:
TRAVIS_PULL_REQUEST_SHA:
if the current job is a pull request, the commit SHA of the HEAD commit of the PR.
I don't think it is a head commit of a base branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds missing provider's environment variables.
Motivation
For impacted tests we will need to gather more info about the pull request, some providers already have this information in the environment variables. With this PR we add those when available (similar to github)
Reviewer's Checklist
golangci-lint runlocally.Unsure? Have a question? Request a review!