Skip to content

feat (internal/civisibility): Parallel EFD support#3488

Merged
tonyredondo merged 21 commits into
mainfrom
tony/civisibility-efd-parallel-support
May 20, 2025
Merged

feat (internal/civisibility): Parallel EFD support#3488
tonyredondo merged 21 commits into
mainfrom
tony/civisibility-efd-parallel-support

Conversation

@tonyredondo

@tonyredondo tonyredondo commented May 5, 2025

Copy link
Copy Markdown
Member

What does this PR do?

This PR enables support for running Early Flake Detection retries in parallel.
It enables with an internal flag because we don't want to expose it to customers yet (we are going to use internally in some repos)

Motivation

In some cases we want to run EFD retries in parallel mode to reduce the total time of execution (mostly when each retry take a long time to finish).

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running golangci-lint run locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented May 5, 2025

Copy link
Copy Markdown

Datadog Report

Branch report: tony/civisibility-efd-parallel-support
Commit report: 637a5d3
Test service: dd-trace-go

✅ 0 Failed, 4526 Passed, 64 Skipped, 3m 22.46s Total Time

@pr-commenter

pr-commenter Bot commented May 5, 2025

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-05-20 12:06:18

Comparing candidate commit 0ef8a84 in PR branch tony/civisibility-efd-parallel-support with baseline commit e92a055 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 0 unstable metrics.

@tonyredondo tonyredondo changed the title Tony/civisibility efd parallel support feat (internal/civisibility): Parallel EFD support May 5, 2025
@tonyredondo
tonyredondo marked this pull request as ready for review May 5, 2025 16:10
@tonyredondo
tonyredondo requested review from a team as code owners May 5, 2025 16:10
@tonyredondo
tonyredondo requested a review from BSanchidrian May 5, 2025 16:10
@datadog-datadog-prod-us1

Copy link
Copy Markdown

Datadog Summary

✅ Code Quality    ✅ Code Security    ✅ Dependencies


Was this helpful? Give us feedback!

@tonyredondo
tonyredondo enabled auto-merge (squash) May 20, 2025 11:40
@tonyredondo
tonyredondo disabled auto-merge May 20, 2025 11:53
@tonyredondo
tonyredondo enabled auto-merge (squash) May 20, 2025 11:58
@tonyredondo
tonyredondo merged commit 9e5ccde into main May 20, 2025
@tonyredondo
tonyredondo deleted the tony/civisibility-efd-parallel-support branch May 20, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants