contrib/k8s.io/gateway-api: Request mirror deployment by eliottness · Pull Request #3486 · DataDog/dd-trace-go

eliottness · 2025-05-05T08:43:39Z

What does this PR do?

Create a way to deploy the request mirror in kubernetes in a relatively simple way (read README.md)

Motivation

Better onboarding for Appsec customers

Reviewer's Checklist

Changed code has unit tests for its functionality at or near 100% coverage.
System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
There is a benchmark for any new code, or changes to existing code.
If this interacts with the agent in a new way, a system test has been added.
New code is free of linting errors. You can check this by running golangci-lint run locally.
Add an appropriate team label so this PR gets put in the right place for the release notes.
Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

eliottness · 2025-05-05T08:44:04Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

datadog-datadog-prod-us1 · 2025-05-05T08:53:27Z

Datadog Report

Branch report: eliottness/request-mirror-deployment
Commit report: 88e478f
Test service: dd-trace-go

✅ 0 Failed, 4526 Passed, 64 Skipped, 3m 51s Total Time

pr-commenter · 2025-05-05T09:12:52Z

Benchmarks

Benchmark execution time: 2025-05-19 13:01:02

Comparing candidate commit e0d7ce5 in PR branch eliottness/request-mirror-deployment with baseline commit e09237f in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 1 unstable metrics.

datadog-datadog-prod-us1 · 2025-05-12T13:55:50Z

Datadog Summary

✅ Code Quality ✅ Code Security ✅ Dependencies ❌ Pipelines

Next Steps

The following jobs failed due to code errors:

Check Pull Request CI Status / all-jobs-are-green

Multiple contribution tests failed. Contrib tests for 'gomemcache' and 'sarama' had failures.

The following jobs failed due to platform errors:

Pull Request Tests / PR Unit and Integration Tests / test-contrib-matrix (./contrib/IBM/sarama/ ./contrib/confluentinc/confluent-kafka-go/kafka/ ./con...

Failed to update geoip database: database file changed.

Pull Request Tests / PR Unit and Integration Tests / test-contrib

Process exited with code 1 during execution of 'echo "Failure!"' command.

Was this helpful? Give us feedback!

RomainMuller · 2025-05-12T15:20:57Z

+requests to a Datadog Application Security Monitoring (ASM) endpoint. This allows real-time detection and analysis of
+potential application-level attacks, such as:


MAYBE we want to mention that this is "real-time without impacting the service's latency"; as opposed to in-app WAF which is also real-time but adds latency? Optional.

RomainMuller · 2025-05-12T15:24:01Z

+
+1. [Deploy the Datadog agent in your Kubernetes cluster](https://docs.datadoghq.com/containers/kubernetes/installation/)
+
+2. [Configure the Datadog agent to support incoming Appsec payloads](https://docs.datadoghq.com/tracing/guide/setting_up_apm_with_kubernetes_service/)


Probably will confuse folks that the link says "support incoming Appsec payloads" (the capitalization of "Appsec" is also off), but the page is about setting up APM?

Do you have suggestion for this? I know it can be confusing but I have no really good way to explain it

How about "Set up APM with your Kubernetes service, as this is used as a transport for AppSec payloads"?

Signed-off-by: Eliott Bouhana <[email protected]>

eliottness · 2025-05-19T13:16:32Z

Merge activity

May 19, 9:16 AM EDT: A user started a stack merge that includes this pull request via Graphite.
May 19, 9:16 AM EDT: @eliottness merged this pull request with Graphite.

This was referenced May 5, 2025

contrib/k8s.io/gateway-api: bootstrap #3447

Merged

internal/appsec: fix APISec in standalone mode #3485

Merged

github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label May 5, 2025

eliottness requested a review from e-n-0 May 5, 2025 08:47

eliottness removed the apm:ecosystem contrib/* related feature requests or bugs label May 5, 2025

eliottness added the appsec label May 5, 2025 — with Graphite App

github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label May 5, 2025

eliottness marked this pull request as ready for review May 5, 2025 08:49

eliottness requested review from a team as code owners May 5, 2025 08:49

eliottness force-pushed the eliottness/request-mirror-deployment branch from bd56c3a to 7ceb9a2 Compare May 5, 2025 09:31

eliottness force-pushed the eliottness/fix-apisec-standalone branch from 5d9c40f to f535fc2 Compare May 5, 2025 09:31

eliottness requested a review from RamyElkest May 7, 2025 08:34

e-n-0 reviewed May 7, 2025

View reviewed changes

Comment thread .github/workflows/docker-build-and-push.yml

e-n-0 approved these changes May 7, 2025

View reviewed changes

eliottness force-pushed the eliottness/request-mirror-deployment branch from 7ceb9a2 to c68f486 Compare May 9, 2025 11:46

eliottness force-pushed the eliottness/fix-apisec-standalone branch from f535fc2 to 9be7749 Compare May 9, 2025 11:46

eliottness force-pushed the eliottness/request-mirror-deployment branch from c68f486 to 3ae47ba Compare May 9, 2025 11:48

eliottness force-pushed the eliottness/fix-apisec-standalone branch from 9be7749 to 1aff868 Compare May 9, 2025 11:48

Base automatically changed from eliottness/fix-apisec-standalone to main May 9, 2025 12:21

eliottness force-pushed the eliottness/request-mirror-deployment branch 3 times, most recently from ba3f309 to 9fa20a7 Compare May 12, 2025 13:53

RomainMuller reviewed May 12, 2025

View reviewed changes

eliottness requested a review from RomainMuller May 14, 2025 12:45

RomainMuller approved these changes May 16, 2025

View reviewed changes

eliottness force-pushed the eliottness/request-mirror-deployment branch from 7e8298a to 54430cf Compare May 19, 2025 09:01

eliottness added 4 commits May 19, 2025 14:27

contrib/k8s.io/gateway-api: Request mirror deployment

df46242

Signed-off-by: Eliott Bouhana <[email protected]>

fix misc issues and add simple tests

4cf260c

Signed-off-by: Eliott Bouhana <[email protected]>

fix go.mod tidy

6e5e395

Signed-off-by: Eliott Bouhana <[email protected]>

apply @RomainMuller suggestions

e89fa56

Signed-off-by: Eliott Bouhana <[email protected]>

eliottness force-pushed the eliottness/request-mirror-deployment branch from 54430cf to ecdf173 Compare May 19, 2025 12:28

missed one comment about stdout

e0d7ce5

Signed-off-by: Eliott Bouhana <[email protected]>

eliottness force-pushed the eliottness/request-mirror-deployment branch from ecdf173 to e0d7ce5 Compare May 19, 2025 12:31

eliottness merged commit 1153ba4 into main May 19, 2025

eliottness deleted the eliottness/request-mirror-deployment branch May 19, 2025 13:16

		requests to a Datadog Application Security Monitoring (ASM) endpoint. This allows real-time detection and analysis of
		potential application-level attacks, such as:


		1. [Deploy the Datadog agent in your Kubernetes cluster](https://docs.datadoghq.com/containers/kubernetes/installation/)

		2. [Configure the Datadog agent to support incoming Appsec payloads](https://docs.datadoghq.com/tracing/guide/setting_up_apm_with_kubernetes_service/)

Uh oh!

Conversation

eliottness commented May 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Reviewer's Checklist

Uh oh!

eliottness commented May 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

datadog-datadog-prod-us1 Bot commented May 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Datadog Report

Uh oh!

pr-commenter Bot commented May 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Uh oh!

Uh oh!

datadog-datadog-prod-us1 Bot commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Datadog Summary

Next Steps

Uh oh!

RomainMuller May 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

RomainMuller May 12, 2025

Choose a reason for hiding this comment

Uh oh!

eliottness May 14, 2025

Choose a reason for hiding this comment

Uh oh!

RomainMuller May 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eliottness commented May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

eliottness commented May 5, 2025 •

edited

Loading

eliottness commented May 5, 2025 •

edited

Loading

datadog-datadog-prod-us1 Bot commented May 5, 2025 •

edited

Loading

pr-commenter Bot commented May 5, 2025 •

edited

Loading

datadog-datadog-prod-us1 Bot commented May 12, 2025 •

edited

Loading

eliottness commented May 19, 2025 •

edited

Loading