Skip to content

internal/appsec: fix APISec in standalone mode#3485

Merged
eliottness merged 2 commits into
mainfrom
eliottness/fix-apisec-standalone
May 9, 2025
Merged

internal/appsec: fix APISec in standalone mode#3485
eliottness merged 2 commits into
mainfrom
eliottness/fix-apisec-standalone

Conversation

@eliottness

@eliottness eliottness commented May 5, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR manually set spans generating APIsec schemas to Manual Keep priority when Appsec Standalone (alias tracing as transport). Otherwise schemas will always be sampled away

Motivation

https://datadoghq.atlassian.net/browse/APPSEC-57337

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running golangci-lint run locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@eliottness Graphite App

eliottness commented May 5, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced May 5, 2025
Merged
Merged
@eliottness
eliottness requested a review from RamyElkest May 5, 2025 08:47
@eliottness eliottness added the appsec label May 5, 2025 — with Graphite App
@eliottness
eliottness marked this pull request as ready for review May 5, 2025 08:47
@eliottness
eliottness requested review from a team as code owners May 5, 2025 08:47
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented May 5, 2025 •
edited
Loading

Copy link
Copy Markdown

Datadog Report

Branch report: eliottness/fix-apisec-standalone
Commit report: c241987
Test service: dd-trace-go

✅ 0 Failed, 4525 Passed, 65 Skipped, 3m 55.03s Total Time

@pr-commenter

pr-commenter Bot commented May 5, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-05-09 12:18:23

Comparing candidate commit 1aff868 in PR branch eliottness/fix-apisec-standalone with baseline commit d17f78d in branch main.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 0 unstable metrics.

scenario:BenchmarkInjectW3C-24

  • 🟩 execution_time [-166.777ns; -145.223ns] or [-3.943%; -3.433%]

scenario:BenchmarkSetTagStringer-24

  • 🟩 execution_time [-5.862ns; -3.338ns] or [-3.942%; -2.244%]

@eliottness
eliottness force-pushed the eliottness/traffic-mirror-2 branch from 053de5e to 35e5f46 Compare May 5, 2025 09:31
@eliottness
eliottness force-pushed the eliottness/fix-apisec-standalone branch from 5d9c40f to f535fc2 Compare May 5, 2025 09:31
@RamyElkest

RamyElkest commented May 8, 2025

Copy link
Copy Markdown
Contributor

will need to rebase on main

@eliottness
eliottness force-pushed the eliottness/traffic-mirror-2 branch from 35e5f46 to 584df20 Compare May 9, 2025 11:46
@eliottness
eliottness force-pushed the eliottness/fix-apisec-standalone branch from f535fc2 to 9be7749 Compare May 9, 2025 11:46
@eliottness
eliottness force-pushed the eliottness/traffic-mirror-2 branch from 584df20 to 934faae Compare May 9, 2025 11:48
@eliottness
eliottness force-pushed the eliottness/fix-apisec-standalone branch from 9be7749 to 1aff868 Compare May 9, 2025 11:48
Base automatically changed from eliottness/traffic-mirror-2 to main May 9, 2025 12:00
@eliottness
eliottness requested a review from a team as a code owner May 9, 2025 12:00
@github-actions github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label May 9, 2025
@eliottness
eliottness merged commit 448466c into main May 9, 2025
@eliottness
eliottness deleted the eliottness/fix-apisec-standalone branch May 9, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darccio darccio darccio approved these changes
@genesor genesor genesor approved these changes
@RamyElkest RamyElkest RamyElkest approved these changes

Assignees

No one assigned

Labels

apm:ecosystem contrib/* related feature requests or bugs appsec

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eliottness @RamyElkest @darccio @genesor