Skip to content

feat(http): add round tripper option for status check functionality and corresponding tests#3480

Merged
darccio merged 1 commit into
mainfrom
dario.castane/net-http-statuscheck
May 2, 2025
Merged

feat(http): add round tripper option for status check functionality and corresponding tests#3480
darccio merged 1 commit into
mainfrom
dario.castane/net-http-statuscheck

Conversation

@darccio

@darccio darccio commented May 2, 2025

Copy link
Copy Markdown
Member

What does this PR do?

Ports #3422 to our main (v2 branch). It also removes a linter warning.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running golangci-lint run locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@darccio
darccio requested review from a team as code owners May 2, 2025 09:52
@github-actions github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label May 2, 2025
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented May 2, 2025

Copy link
Copy Markdown

Datadog Report

Branch report: dario.castane/net-http-statuscheck
Commit report: acb5719
Test service: dd-trace-go

✅ 0 Failed, 4525 Passed, 65 Skipped, 3m 46.05s Total Time

@pr-commenter

pr-commenter Bot commented May 2, 2025

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-05-02 11:37:48

Comparing candidate commit fffba84 in PR branch dario.castane/net-http-statuscheck with baseline commit 28a8779 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 1 unstable metrics.

@darccio
darccio force-pushed the dario.castane/net-http-statuscheck branch from 39a3b06 to fffba84 Compare May 2, 2025 11:08
@darccio
darccio merged commit 585f5d6 into main May 2, 2025
@darccio
darccio deleted the dario.castane/net-http-statuscheck branch May 2, 2025 12:33
darccio added a commit that referenced this pull request May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

apm:ecosystem contrib/* related feature requests or bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants