fix(ddtrace/tracer): prevent applying rate to finished spans and add test coverage for this finishing code path#3474
Merged
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 4485 Passed, 65 Skipped, 4m 2.34s Total Time |
felixge
reviewed
Apr 30, 2025
kakkoyun
approved these changes
Apr 30, 2025
…erage for this finishing code path
…ifying spans during flush
darccio
force-pushed
the
dario.castane/finished-check-applyrate
branch
from
April 30, 2025 08:58
aa13d65 to
a9683c5
Compare
BenchmarksBenchmark execution time: 2025-04-30 09:28:41 Comparing candidate commit a9683c5 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 54 metrics, 1 unstable metrics. scenario:BenchmarkInjectW3C-24
|
darccio
added a commit
that referenced
this pull request
Apr 30, 2025
…test coverage for this finishing code path (#3474)
darccio
added a commit
that referenced
this pull request
Apr 30, 2025
…test coverage for this finishing code path (#3474)
7 tasks
darccio
added a commit
that referenced
this pull request
Apr 30, 2025
…test coverage for this finishing code path (#3474)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Prevents race condition from #3472 by adding a
span.finishedcheck to our sampling logic.Reviewer's Checklist
golangci-lint runlocally.Unsure? Have a question? Request a review!