Skip to content

fix(ddtrace/tracer): unexport Span.{,R}{,Un}Lock functions#3457

Merged
darccio merged 1 commit into
mainfrom
dario.castane/span-lock-api-unexport
Apr 23, 2025
Merged

fix(ddtrace/tracer): unexport Span.{,R}{,Un}Lock functions#3457
darccio merged 1 commit into
mainfrom
dario.castane/span-lock-api-unexport

Conversation

@darccio

@darccio darccio commented Apr 23, 2025

Copy link
Copy Markdown
Member

What does this PR do?

Unexports Span.{,R}{,Un}Lock functions, as they were exposed in v2 as side effect of changing span to Span.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running golangci-lint run locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@darccio
darccio requested a review from a team as a code owner April 23, 2025 11:05
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Apr 23, 2025 •
edited
Loading

Copy link
Copy Markdown

Datadog Report

Branch report: dario.castane/span-lock-api-unexport
Commit report: 63360dc
Test service: dd-trace-go

✅ 0 Failed, 4485 Passed, 64 Skipped, 3m 49.31s Total Time

kakkoyun
kakkoyun approved these changes Apr 23, 2025
View reviewed changes

@kakkoyun kakkoyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for taking care of it.

@pr-commenter

pr-commenter Bot commented Apr 23, 2025

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-04-23 11:26:37

Comparing candidate commit 583dd2f in PR branch dario.castane/span-lock-api-unexport with baseline commit a2a7560 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 1 unstable metrics.

@darccio
darccio merged commit 2533b04 into main Apr 23, 2025
@darccio
darccio deleted the dario.castane/span-lock-api-unexport branch April 23, 2025 11:27
darccio added a commit that referenced this pull request Apr 29, 2025
@darccio
ddtrace/tracer: apply changes from #3441, #3446, and #3457
e428405
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kakkoyun kakkoyun kakkoyun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@darccio @kakkoyun